core: carry a MySQL column's UNSIGNED through the analysis core

MySQL declares UNSIGNED on the column rather than in a type of its own,
and the core catalog kept no record of it, so under
SQLCEXPERIMENT=coreanalyzer a BIGINT UNSIGNED column and every placeholder
compared with one came out as int64 instead of uint64.

sql_attribute now records the flag, and it travels the way the column's
other declaration details do: a result column that comes straight from the
table carries it, as does a placeholder that stands in for such a column,
and the catalog dump hands it to codegen for the table models. An ALTER
COLUMN that changes the type sets it afresh.

In the core replay context 11 more cases pass, with no case regressing.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XZcKb4GFiZQbeo9oVmyF3m

Author: claude

internal/compiler/catalog_core.go

@@ -40,10 +40,11 @@ func coreResultCatalog(c *core.Catalog) (*catalog.Catalog, error) {
 				// and codegen renders a "[]" per dimension.
 				dataType, isArray := strings.CutSuffix(col.TypeName, core.ArraySuffix)
 				column := &catalog.Column{
-					Name:      col.Name,
-					Type:      ast.TypeName{Name: dataType},
-					IsNotNull: col.NotNull,
-					IsArray:   isArray,
+					Name:       col.Name,
+					Type:       ast.TypeName{Name: dataType},
+					IsNotNull:  col.NotNull,
+					IsUnsigned: col.Unsigned,
+					IsArray:    isArray,
 				}
 				if isArray {
 					column.ArrayDims = 1

internal/compiler/parse_core.go

@@ -106,6 +106,7 @@ func coreColumn(c core.Column) *Column {
 		NotNull:  c.NotNull,
 		IsArray:  c.IsArray,
 		TypeExpr: c.Type,
+		Unsigned: c.Unsigned,
 	}
 	// The core reports arrays without dimensions, and codegen renders one
 	// "[]" per dimension.
@@ -131,6 +132,7 @@ func coreParamColumn(p core.Parameter, params *named.ParamSet) *Column {
 		NotNull:  p.NotNull,
 		IsArray:  p.IsArray,
 		TypeExpr: p.Type,
+		Unsigned: p.Unsigned,
 	}
 	if p.IsArray {
 		col.ArrayDims = 1

internal/core/analysis.go

@@ -70,6 +70,9 @@ type Column struct {
 	IsPrimaryKey       bool          `json:"is_primary_key,omitempty"`
 	IsUnique           bool          `json:"is_unique,omitempty"`
 	IsAutoIncrement    bool          `json:"is_auto_increment,omitempty"`
+	// Unsigned is the UNSIGNED the column was declared with, when the
+	// column comes straight from a MySQL table.
+	Unsigned bool `json:"unsigned,omitempty"`
 }
 
 type Parameter struct {
@@ -81,4 +84,7 @@ type Parameter struct {
 	NotNull  bool          `json:"not_null"`
 	IsArray  bool          `json:"is_array,omitempty"`
 	Source   *ColumnSource `json:"source,omitempty"`
+	// Unsigned is the UNSIGNED of the MySQL column the placeholder stands
+	// in for, when it stands in for one.
+	Unsigned bool `json:"unsigned,omitempty"`
 }

internal/core/analyzer/expr.go

@@ -223,6 +223,7 @@ func (a *analyzer) inferParam(number int, t exprType) {
 				TableAlias: t.sourceTableAlias,
 				Column:     ad.Column,
 			}
+			cur.Unsigned = ad.Unsigned
 			if typed {
 				cur.Type = a.typeExprOf(t, ad.DeclType)
 			}

internal/core/analyzer/projection.go

@@ -126,6 +126,7 @@ func (a *analyzer) decorateSource(col *core.Column, attOID int64, tableAlias str
 	col.IsPrimaryKey = ad.IsPrimaryKey
 	col.IsUnique = ad.IsUnique
 	col.IsAutoIncrement = ad.AutoIncrement
+	col.Unsigned = ad.Unsigned
 }
 
 // targetName picks the output name for a target. fields is the already

internal/core/attribute.go

@@ -24,6 +24,9 @@ type AttributeSpec struct {
 	// the relation's model, like the column an sqlite fts5 table names
 	// after itself.
 	Hidden bool
+	// Unsigned is the UNSIGNED a MySQL column is declared with, which the
+	// dialect puts on the column rather than in a type of its own.
+	Unsigned bool
 }
 
 func (c *Catalog) CreateAttributeSpec(s AttributeSpec) error {
@@ -41,6 +44,7 @@ func (c *Catalog) CreateAttributeSpec(s AttributeSpec) error {
 		IsPrimaryKey:  boolToInt64(s.IsPrimaryKey),
 		IsUnique:      boolToInt64(s.IsUnique),
 		Hidden:        boolToInt64(s.Hidden),
+		Unsigned:      boolToInt64(s.Unsigned),
 	})
 	if err != nil {
 		return fmt.Errorf("create attribute %q on class %d: %w", s.Name, s.ClassOID, err)
@@ -85,12 +89,13 @@ func (c *Catalog) RenameAttribute(classOID int64, name, newName string) error {
 }
 
 // SetAttributeType changes a column's type.
-func (c *Catalog) SetAttributeType(classOID int64, name string, typeOID int64, declType string) error {
+func (c *Catalog) SetAttributeType(classOID int64, name string, typeOID int64, declType string, unsigned bool) error {
 	err := c.q.SetAttributeType(context.Background(), catalogdb.SetAttributeTypeParams{
 		ClassOid: classOID,
 		Name:     name,
 		TypeOid:  typeOID,
 		DeclType: declType,
+		Unsigned: boolToInt64(unsigned),
 	})
 	if err != nil {
 		return fmt.Errorf("set type of attribute %q on class %d: %w", name, classOID, err)
@@ -244,6 +249,7 @@ type CodegenColumn struct {
 	Name     string
 	TypeName string
 	NotNull  bool
+	Unsigned bool
 }
 
 func (c *Catalog) ClassCodegenColumns(classOID int64) ([]CodegenColumn, error) {
@@ -257,6 +263,7 @@ func (c *Catalog) ClassCodegenColumns(classOID int64) ([]CodegenColumn, error) {
 			Name:     r.ColumnName,
 			TypeName: r.TypeName,
 			NotNull:  r.NotNull != 0,
+			Unsigned: r.Unsigned != 0,
 		})
 	}
 	return out, nil
@@ -274,6 +281,7 @@ type AttributeDetails struct {
 	IsPrimaryKey  bool
 	IsUnique      bool
 	NotNull       bool
+	Unsigned      bool
 }
 
 func (c *Catalog) LookupAttribute(attOID int64) (AttributeDetails, error) {
@@ -293,5 +301,6 @@ func (c *Catalog) LookupAttribute(attOID int64) (AttributeDetails, error) {
 		IsPrimaryKey:  r.IsPrimaryKey != 0,
 		IsUnique:      r.IsUnique != 0,
 		NotNull:       r.NotNull != 0,
+		Unsigned:      r.Unsigned != 0,
 	}, nil
 }

internal/core/catalogdb/models.go

@@ -115,8 +115,8 @@ UPDATE sql_class SET name = sqlc.arg(new_name) WHERE oid = sqlc.arg(oid);
 INSERT INTO sql_attribute (
     class_oid, name, type_oid, not_null, has_default, num,
     decl_type, type_length, type_scale,
-    auto_increment, is_primary_key, is_unique, hidden
-) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);
+    auto_increment, is_primary_key, is_unique, hidden, unsigned
+) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);
 
 -- name: SetAttributePrimaryKey :exec
 UPDATE sql_attribute SET is_primary_key = 1, not_null = 1
@@ -137,7 +137,7 @@ UPDATE sql_attribute SET name = sqlc.arg(new_name)
 WHERE class_oid = sqlc.arg(class_oid) AND name = sqlc.arg(name);
 
 -- name: SetAttributeType :exec
-UPDATE sql_attribute SET type_oid = sqlc.arg(type_oid), decl_type = sqlc.arg(decl_type)
+UPDATE sql_attribute SET type_oid = sqlc.arg(type_oid), decl_type = sqlc.arg(decl_type), unsigned = sqlc.arg(unsigned)
 WHERE class_oid = sqlc.arg(class_oid) AND name = sqlc.arg(name);
 
 -- name: SetAttributeNotNull :exec
@@ -173,7 +173,7 @@ WHERE class_oid = ?
 ORDER BY num;
 
 -- name: ListClassColumns :many
-SELECT a.name AS column_name, t.name AS type_name, a.not_null
+SELECT a.name AS column_name, t.name AS type_name, a.not_null, a.unsigned
 FROM sql_attribute a
 JOIN sql_type t ON t.oid = a.type_oid
 WHERE a.class_oid = ? AND a.hidden = 0
@@ -182,7 +182,7 @@ ORDER BY a.num;
 -- name: LookupAttribute :one
 SELECT ns.name AS schema_name, cls.name AS table_name, a.name AS column_name, a.num,
        a.decl_type, a.type_length, a.type_scale,
-       a.auto_increment, a.is_primary_key, a.is_unique, a.not_null
+       a.auto_increment, a.is_primary_key, a.is_unique, a.not_null, a.unsigned
 FROM sql_attribute a
 JOIN sql_class cls ON cls.oid = a.class_oid
 JOIN sql_namespace ns ON ns.oid = cls.namespace_oid

internal/core/catalogdb/query.sql.go

@@ -78,6 +78,8 @@ CREATE TABLE sql_class (
 --   hidden:          resolvable by name but absent from a star expansion and
 --                    from the relation's model, like the column an sqlite
 --                    fts5 table names after itself.
+--   unsigned:        the column was declared UNSIGNED, which MySQL puts on
+--                    the column rather than in a type of its own.
 CREATE TABLE sql_attribute (
     oid            INTEGER PRIMARY KEY AUTOINCREMENT,
     class_oid      INTEGER NOT NULL REFERENCES sql_class(oid),
@@ -93,6 +95,7 @@ CREATE TABLE sql_attribute (
     is_primary_key INTEGER NOT NULL DEFAULT 0,
     is_unique      INTEGER NOT NULL DEFAULT 0,
     hidden         INTEGER NOT NULL DEFAULT 0,
+    unsigned       INTEGER NOT NULL DEFAULT 0,
     UNIQUE(class_oid, name),
     UNIQUE(class_oid, num)
 );