Revert "Add RNRepo to ci builds (#4141)"#4150
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
This reverts commit 451eb50.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the earlier RNRepo CI integration to restore expected native build behavior for the example apps (notably expo-example Android), by removing RNRepo tooling/config and undoing related CI and build-script changes.
Changes:
- Removes RNRepo packages/configuration from the repo and example apps.
- Reverts iOS/Android example-app build script modifications that enabled RNRepo in CI.
- Adjusts CI workflows accordingly (including Android Gradle invocation and path filters).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes RNRepo and related Expo config-plugin lock entries introduced by the reverted change. |
| rnrepo.config.json | Deletes RNRepo configuration file. |
| apps/expo-example/package.json | Removes RNRepo Expo config plugin dev dependency. |
| apps/expo-example/app.config.js | Removes RNRepo Expo config plugin from Expo plugins list. |
| apps/basic-example/package.json | Removes RNRepo build-tools dev dependency. |
| apps/basic-example/ios/Podfile | Removes RNRepo CocoaPods plugin enablement and post-install hook usage. |
| apps/basic-example/android/build.gradle | Removes RNRepo Gradle plugin classpath wiring. |
| apps/basic-example/android/app/build.gradle | Removes conditional RNRepo plugin application. |
| .github/workflows/ios-build.yml | Updates PR path filters to drop RNRepo-related triggers. |
| .github/workflows/android-build.yml | Updates PR path filters and changes the Gradle build command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
8
| - .github/workflows/android-build.yml | ||
| - packages/react-native-gesture-handler/android/** | ||
| - apps/basic-example/android/** |
| - name: Build app | ||
| working-directory: ${{ matrix.working-directory }}/android | ||
| run: ./gradlew :app:assembleDebug --console=plain -PreactNativeArchitectures=arm64-v8a | ||
| run: ./gradlew assembleDebug --console=plain -PreactNativeArchitectures=arm64-v8a |
Comment on lines
3
to
10
| on: | ||
| pull_request: | ||
| paths: | ||
| - .github/workflows/ios-build.yml | ||
| - packages/react-native-gesture-handler/RNGestureHandler.podspec | ||
| - packages/react-native-gesture-handler/apple/** | ||
| - apps/basic-example/ios/** | ||
| - apps/basic-example/package.json | ||
| - rnrepo.config.json | ||
| - yarn.lock | ||
| push: |
Contributor
|
#4151 was the fix @j-piasecki - this can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 451eb50.
Description
expo-exampleon Android stopped working with