fix(cli): isolate embedded output from host process logging

Author: Sg312

packages/sim-cli/src/auth/device-flow.ts

@@ -1,4 +1,5 @@
 import { createHash, randomBytes, randomInt } from 'node:crypto'
+import { writeStderr } from '#cli/output/io'
 import { sleep } from '../helpers'
 import { buildUrl, REDIRECT_STATUSES, redirectEndpoint, SimApiError } from '../http/client'
 import { userAgent } from '../version'
@@ -207,7 +208,7 @@ export async function pollForKey(
         consecutiveTransportFailures >= TRANSPORT_FAILURES_BEFORE_WARNING
       ) {
         warnedAboutTransport = true
-        process.stderr.write(
+        writeStderr(
           `Still waiting: ${endpoint} is not answering the login poll (${(cause as Error).message}). Check the endpoint; retrying until you approve or the login times out.\n`
         )
       }

packages/sim-cli/src/commands/auth.ts

@@ -1,6 +1,7 @@
 import { spawn } from 'node:child_process'
 import { createInterface } from 'node:readline/promises'
 import { Command } from 'commander'
+import { printLine } from '#cli/output/io'
 import { styles } from '#cli/output/presentation'
 import {
   buildApprovalUrl,
@@ -212,9 +213,9 @@ async function chooseWorkspace(client: Pick<SimClient, 'request'>): Promise<Sele
     )
   }
 
-  console.log('\nAvailable workspaces:')
+  printLine('\nAvailable workspaces:')
   for (const [index, workspace] of workspaces.entries()) {
-    console.log(`  ${index + 1}) ${safeOneLine(workspace.name)} (${workspace.id})`)
+    printLine(`  ${index + 1}) ${safeOneLine(workspace.name)} (${workspace.id})`)
   }
 
   const prompt = createInterface({ input: process.stdin, output: process.stderr })
@@ -257,12 +258,10 @@ function addProfileCommand(): Command {
         workspace: normalizeWorkspaceId(workspace.id, 'the workspace response'),
       })
 
-      console.log(
-        styles().green(`✓ Added profile "${safeOneLine(profileName)}" in ${configPath()}`)
-      )
-      console.log(`  Workspace: ${safeOneLine(workspace.name)} (${workspace.id})`)
-      console.log(`  Authentication: ${safeOneLine(authProfile)}`)
-      console.log(styles().dim(`  Try: sim --profile ${safeOneLine(profileName)} whoami`))
+      printLine(styles().green(`✓ Added profile "${safeOneLine(profileName)}" in ${configPath()}`))
+      printLine(`  Workspace: ${safeOneLine(workspace.name)} (${workspace.id})`)
+      printLine(`  Authentication: ${safeOneLine(authProfile)}`)
+      printLine(styles().dim(`  Try: sim --profile ${safeOneLine(profileName)} whoami`))
     })
 }
 
@@ -294,7 +293,7 @@ export function loginCommand(): Command {
         if (readCredentialsProfile(profile.name).api_key && !options.yes) {
           const confirmed = await confirmProfileOverwrite(profile.name)
           if (!confirmed) {
-            console.log(styles().dim('Login cancelled; the existing profile was not changed.'))
+            printLine(styles().dim('Login cancelled; the existing profile was not changed.'))
             return
           }
         }
@@ -307,17 +306,17 @@ export function loginCommand(): Command {
           profile.workspaceId ?? undefined
         )
 
-        console.log(
+        printLine(
           `Signing in to ${styles().bold(profile.endpoint)} as profile ${styles().bold(safeOneLine(profile.name))}`
         )
-        console.log(`\nPairing code: ${styles().bold(auth.pairing)}`)
-        console.log(
+        printLine(`\nPairing code: ${styles().bold(auth.pairing)}`)
+        printLine(
           styles().dim('Confirm this code matches what the browser shows before approving.\n')
         )
-        console.log(url)
+        printLine(url)
 
         if (options.browser) openBrowser(url)
-        console.log(styles().dim('\nWaiting for approval…'))
+        printLine(styles().dim('\nWaiting for approval…'))
 
         const key = await pollForKey(profile.endpoint, auth)
 
@@ -360,19 +359,17 @@ export function loginCommand(): Command {
         writeConfigProfile(profile.name, settings)
         writeCredentialsProfile(profile.name, key.apiKey)
 
-        console.log(styles().green(`\n✓ Logged in. Key stored in ${credentialsPath()}`))
+        printLine(styles().green(`\n✓ Logged in. Key stored in ${credentialsPath()}`))
         if (key.workspaceBound && key.workspaceId) {
-          console.log(
-            styles().dim(`  Workspace-scoped key — it can only reach ${key.workspaceId}.`)
-          )
+          printLine(styles().dim(`  Workspace-scoped key — it can only reach ${key.workspaceId}.`))
         } else if (key.workspaceId) {
-          console.log(
+          printLine(
             styles().dim(
               `  Personal key, defaulting to ${key.workspaceId}. Override per command with --workspace.`
             )
           )
         } else {
-          console.log(
+          printLine(
             styles().dim(
               '  Personal key with no default workspace. Set one with: sim configure --set-workspace <id>'
             )
@@ -398,10 +395,10 @@ export function logoutCommand(): Command {
         }
         const removed = deleteProfile(profileName)
         if (!removed.config && !removed.credentials) {
-          console.log(styles().dim(`Nothing stored for profile "${safeOneLine(profileName)}".`))
+          printLine(styles().dim(`Nothing stored for profile "${safeOneLine(profileName)}".`))
           return
         }
-        console.log(styles().green(`✓ Removed profile "${safeOneLine(profileName)}".`))
+        printLine(styles().green(`✓ Removed profile "${safeOneLine(profileName)}".`))
         return
       }
 
@@ -415,17 +412,17 @@ export function logoutCommand(): Command {
       }
 
       if (!readCredentialsProfile(profile.name).api_key) {
-        console.log(styles().dim(`No stored key for profile "${safeOneLine(profile.name)}".`))
+        printLine(styles().dim(`No stored key for profile "${safeOneLine(profile.name)}".`))
         return
       }
 
       writeCredentialsProfile(profile.name, null)
-      console.log(
+      printLine(
         styles().green(`✓ Removed the stored key for profile "${safeOneLine(profile.name)}".`)
       )
       // The key still exists server-side; leaving that unsaid invites the
       // assumption that logging out revoked it.
-      console.log(
+      printLine(
         styles().dim('  The key itself is still active — revoke it in Settings → Sim API keys.')
       )
     })
@@ -759,7 +756,7 @@ export function profilesCommand(): Command {
     if (rows.length === 0) {
       // The prose belongs to the human formats; a script asking for json must
       // get an empty list, not a sentence it cannot parse.
-      if (output === 'table') console.log(styles().dim('No profiles yet. Run: sim login'))
+      if (output === 'table') printLine(styles().dim('No profiles yet. Run: sim login'))
       else printList(output, rows, PROFILE_COLUMNS)
       return
     }

packages/sim-cli/src/commands/configure.ts

@@ -1,4 +1,5 @@
 import { Command } from 'commander'
+import { printLine } from '#cli/output/io'
 import { styles } from '#cli/output/presentation'
 import {
   configPath,
@@ -154,11 +155,11 @@ export function configureCommand(): Command {
         if (Object.keys(updates).length === 0) {
           const current = readConfigProfile(profile.name)
           if (Object.keys(current).length === 0) {
-            console.log(styles().dim(`No settings stored for profile "${profile.name}".`))
+            printLine(styles().dim(`No settings stored for profile "${profile.name}".`))
             return
           }
           for (const [key, value] of Object.entries(current)) {
-            console.log(`${styles().dim(`${key}:`)} ${value}`)
+            printLine(`${styles().dim(`${key}:`)} ${value}`)
           }
           return
         }
@@ -168,12 +169,12 @@ export function configureCommand(): Command {
         // an update would claim a change that did not happen.
         const removalOnly = Object.values(updates).every((value) => value === null)
         if (removalOnly && Object.keys(readConfigProfile(profile.name)).length === 0) {
-          console.log(styles().dim(`No settings stored for profile "${profile.name}".`))
+          printLine(styles().dim(`No settings stored for profile "${profile.name}".`))
           return
         }
 
         writeConfigProfile(profile.name, updates)
-        console.log(styles().green(`✓ Updated profile "${profile.name}" in ${configPath()}`))
+        printLine(styles().green(`✓ Updated profile "${profile.name}" in ${configPath()}`))
       }
     )
 }

packages/sim-cli/src/commands/protocol/chat.ts

@@ -1,4 +1,6 @@
 import type { Command } from 'commander'
+import { embedStore } from '#cli/embed-context'
+import { writeStderr, writeStdout } from '#cli/output/io'
 import { styles } from '#cli/output/presentation'
 import { clientFrom } from '../../context'
 import { type ChatResponse, V2_OPERATIONS } from '../../generated/v2-api'
@@ -204,18 +206,19 @@ Examples:
       /** Closes off streamed text so nothing is glued onto the line after it. */
       const endStreamedLine = (): void => {
         if (streamed.length > 0 && !streamed.endsWith('\n')) {
-          process.stdout.write('\n')
+          writeStdout('\n')
           streamed += '\n'
         }
       }
 
-      const restorePipeHandling = streaming ? ignoreBrokenPipe(process.stdout) : undefined
+      const restorePipeHandling =
+        streaming && !embedStore.getStore() ? ignoreBrokenPipe(process.stdout) : undefined
 
       try {
         const result = await readChatStream(response, (content) => {
           if (!streaming) return
           streamed += content
-          process.stdout.write(content)
+          writeStdout(content)
         })
 
         if (!streaming) {
@@ -230,11 +233,11 @@ Examples:
         // rather than duplicating the reply.
         const content = sanitize(result.content ?? '')
         if (content.startsWith(streamed) && content.length > streamed.length) {
-          process.stdout.write(content.slice(streamed.length))
+          writeStdout(content.slice(streamed.length))
           streamed = content
         }
         endStreamedLine()
-        process.stderr.write(`${styles().dim(`conversation: ${result.conversationId}`)}\n`)
+        writeStderr(`${styles().dim(`conversation: ${result.conversationId}`)}\n`)
       } catch (error) {
         endStreamedLine()
         throw error

packages/sim-cli/src/commands/protocol/files-get.ts

@@ -5,6 +5,7 @@ import { dirname, join, resolve } from 'node:path'
 import { Readable, type Writable } from 'node:stream'
 import { pipeline } from 'node:stream/promises'
 import type { Command } from 'commander'
+import { writeStdout } from '#cli/output/io'
 import { clientFrom } from '../../context'
 import { embedStore } from '../../embed-context'
 import { V2_OPERATIONS } from '../../generated/v2-api'
@@ -227,14 +228,18 @@ export async function saveToFile(
 /** Streams a fetch body to stdout without closing the process-wide stream. */
 export async function streamToStdout(
   body: ReadableStream<Uint8Array>,
-  output: NodeJS.WriteStream = process.stdout
+  output?: NodeJS.WriteStream
 ): Promise<void> {
   const reader = body.getReader()
   try {
     while (true) {
       const { done, value } = await reader.read()
       if (done) return
-      if (!output.write(value)) await once(output, 'drain')
+      if (output) {
+        if (!output.write(value)) await once(output, 'drain')
+      } else if (!writeStdout(value)) {
+        await once(process.stdout, 'drain')
+      }
     }
   } finally {
     await reader.cancel().catch(() => {})

packages/sim-cli/src/commands/protocol/logs-follow.ts

@@ -1,5 +1,6 @@
 import { type Command, Option } from 'commander'
 import { dump } from 'js-yaml'
+import { printLine, writeStderr } from '#cli/output/io'
 import { hasProgressTerminal, styles } from '#cli/output/presentation'
 import type { OutputFormat } from '../../config/index'
 import { clientFrom } from '../../context'
@@ -213,7 +214,7 @@ function createTableWriter(): RowWriter {
         )
       )
       const header = widths
-      console.log(
+      printLine(
         styles().dim(
           COLUMNS.map((column, index) => pad(column.header.toUpperCase(), header[index]))
             .join('  ')
@@ -224,7 +225,7 @@ function createTableWriter(): RowWriter {
 
     const locked = widths
     for (const line of lines) {
-      console.log(
+      printLine(
         line
           .map((cell, index) => pad(cell, locked[index]))
           .join('  ')
@@ -246,13 +247,13 @@ function createTableWriter(): RowWriter {
 function createWriter(format: OutputFormat): RowWriter {
   if (format === 'json') {
     return (rows) => {
-      for (const row of rows) console.log(JSON.stringify(row))
+      for (const row of rows) printLine(JSON.stringify(row))
     }
   }
   if (format === 'yaml') {
     return (rows) => {
       for (const row of rows) {
-        console.log(`---\n${dump(row, { lineWidth: 0, noRefs: true }).trimEnd()}`)
+        printLine(`---\n${dump(row, { lineWidth: 0, noRefs: true }).trimEnd()}`)
       }
     }
   }
@@ -292,19 +293,19 @@ export function followStatus(): FollowStatus {
     note: (message) => {
       if (!hasProgressTerminal()) return
       reported = true
-      process.stderr.write(`\r${styles().dim(message)}${ERASE_LINE}`)
+      writeStderr(`\r${styles().dim(message)}${ERASE_LINE}`)
     },
     warn: (message) => {
       if (reported) {
         reported = false
-        process.stderr.write(`\r${ERASE_LINE}`)
+        writeStderr(`\r${ERASE_LINE}`)
       }
-      process.stderr.write(`warning: ${message}\n`)
+      writeStderr(`warning: ${message}\n`)
     },
     clear: () => {
       if (!reported) return
       reported = false
-      process.stderr.write(`\r${ERASE_LINE}`)
+      writeStderr(`\r${ERASE_LINE}`)
     },
   }
 }

packages/sim-cli/src/commands/protocol/tables-import.ts

@@ -1,5 +1,6 @@
 import { setTimeout as sleep } from 'node:timers/promises'
 import { type Command, Option } from 'commander'
+import { writeStderr } from '#cli/output/io'
 import { hasProgressTerminal, styles } from '#cli/output/presentation'
 import { clientFrom } from '../../context'
 import type {
@@ -109,11 +110,11 @@ async function watchImport(
     const line = progressLine(current)
     if (hasProgressTerminal() && line !== reported) {
       reported = line
-      process.stderr.write(`\r${styles().dim(line)}\u001b[K`)
+      writeStderr(`\r${styles().dim(line)}\u001b[K`)
     }
   }
 
-  if (hasProgressTerminal() && reported !== null) process.stderr.write('\r\u001b[K')
+  if (hasProgressTerminal() && reported !== null) writeStderr('\r\u001b[K')
   return current
 }
 

packages/sim-cli/src/commands/protocol/workflow-run-follow.ts

@@ -1,4 +1,5 @@
 import type { Command } from 'commander'
+import { writeStderr } from '#cli/output/io'
 import { styles } from '#cli/output/presentation'
 import { clientFrom } from '../../context'
 import { CLI_CONTRACT } from '../../contract/commands'
@@ -312,7 +313,7 @@ async function followRun(workflowId: string, command: Command): Promise<void> {
   const final = await renderRunStream(response.body, {
     includeThinking,
     includeToolCalls,
-    stderr: process.stderr,
+    stderr: { write: writeStderr },
   })
 
   renderResult('executeWorkflow', profile.output, final, CLI_CONTRACT.executeWorkflow ?? {})