Commit ac07b0c
committed
fix(connectors): order Confluence spaces by name and stop implying a space is missing
Confluence defaults /spaces to id-ascending, which interleaves the site's
personal spaces (one per user) with team spaces in arbitrary order. The selector
drains pages in the background and filters client-side, so on a large site a
space can be absent from the dropdown purely because its id sorts late — it
reads as "this space does not exist" and sends users off to type the key by
hand. Sorting by name makes the drained prefix an alphabetical prefix.
The connector selector field also ignored the drain state the shared hook
already exposes, so a still-filling list showed "No spaces found". It now
reports that the list is still loading, and says so honestly when the drain
stops at its page cap.1 parent cb3611b commit ac07b0c
2 files changed
Lines changed: 39 additions & 4 deletions
File tree
- apps/sim/app
- api/tools/confluence/selector-spaces
- workspace/[workspaceId]/knowledge/[id]/components/connector-selector-field
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
104 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
105 | 120 | | |
106 | 121 | | |
107 | 122 | | |
| |||
Lines changed: 23 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
70 | 90 | | |
71 | 91 | | |
72 | 92 | | |
| |||
99 | 119 | | |
100 | 120 | | |
101 | 121 | | |
102 | | - | |
| 122 | + | |
103 | 123 | | |
104 | 124 | | |
105 | 125 | | |
| |||
120 | 140 | | |
121 | 141 | | |
122 | 142 | | |
123 | | - | |
| 143 | + | |
124 | 144 | | |
125 | 145 | | |
126 | 146 | | |
| |||
0 commit comments