fix(chat): preserve password visibility on regenerate

Author: j15z

apps/sim/components/ui/generated-password-input.test.tsx

@@ -134,14 +134,26 @@ describe('GeneratedPasswordInput', () => {
     expect(passwordInput()).not.toHaveAttribute('placeholder', '••••••••')
   })
 
-  it('reveals a generated password without fetching the saved password', () => {
+  it('keeps a generated password hidden when the field is hidden', () => {
     const fetchCurrentPassword = vi.fn().mockResolvedValue('saved-secret')
     const onChange = vi.fn()
     renderInput({ fetchCurrentPassword, onChange, showGenerate: true })
 
     act(() => passwordButton('Generate password').click())
 
     expect(fetchCurrentPassword).not.toHaveBeenCalled()
+    expect(passwordInput()).toHaveAttribute('type', 'password')
+    expect(onChange).toHaveBeenCalledWith(expect.stringMatching(/^.{24}$/))
+  })
+
+  it('keeps a generated password visible when the field is visible', async () => {
+    const fetchCurrentPassword = vi.fn().mockResolvedValue('saved-secret')
+    const onChange = vi.fn()
+    renderInput({ fetchCurrentPassword, onChange, showGenerate: true })
+
+    await act(async () => passwordButton('Show password').click())
+    act(() => passwordButton('Generate password').click())
+
     expect(passwordInput()).toHaveAttribute('type', 'text')
     expect(onChange).toHaveBeenCalledWith(expect.stringMatching(/^.{24}$/))
   })

apps/sim/components/ui/generated-password-input.tsx

@@ -66,7 +66,6 @@ export function GeneratedPasswordInput({
 
   const handleGeneratePassword = () => {
     handleChange(generatePassword(24))
-    setShowPassword(true)
   }
 
   const toggleShowPassword = async () => {