Skip to content

Commit 7f543aa

Browse files
committed
docs(tools): cover tool removal in the regeneration guidance
The three tool-authoring skills said to regenerate after adding or changing a tool, but not after removing one. Removal is equally breaking and equally guarded: deleting a tool from `tools/registry.ts` without regenerating fails `tool-metadata:check` (verified — exit 1), so a contributor following the skill literally would have hit a CI failure the skill never warned about.
1 parent 9400e01 commit 7f543aa

9 files changed

Lines changed: 12 additions & 12 deletions

File tree

.agents/skills/add-block/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@ Derive templates from the service's real use cases. Each prompt should name a co
923923

924924
Adding a block on its own needs **no** regeneration — a block references existing tool IDs through `tools.access` and does not change any tool's shape.
925925

926-
But if the same change also adds or edits a tool, run `bun run tool-metadata:generate` and commit the result, or CI fails on stale artifacts. That matters here because a block's `outputs` are authored to match its tools' outputs, and the UI now reads those from the generated metadata rather than the executable registry — an unregenerated tool change makes the block's outputs disagree with what the panel renders. See `.agents/skills/tool-registry-boundary/SKILL.md`.
926+
But if the same change also adds, edits **or removes** a tool, run `bun run tool-metadata:generate` and commit the result, or CI fails on stale artifacts. That matters here because a block's `outputs` are authored to match its tools' outputs, and the UI now reads those from the generated metadata rather than the executable registry — an unregenerated tool change makes the block's outputs disagree with what the panel renders. See `.agents/skills/tool-registry-boundary/SKILL.md`.
927927

928928
## Checklist Before Finishing
929929

@@ -939,7 +939,7 @@ But if the same change also adds or edits a tool, run `bun run tool-metadata:gen
939939
- [ ] Tools.config.tool returns correct tool ID (snake_case)
940940
- [ ] Outputs match tool outputs
941941
- [ ] Block + meta registered in registry-maps.ts (`BLOCK_REGISTRY` / `BLOCK_META_REGISTRY`)
942-
- [ ] If any tool was added or changed alongside the block: ran `bun run tool-metadata:generate` and committed the artifacts
942+
- [ ] If any tool was added, changed or removed alongside the block: ran `bun run tool-metadata:generate` and committed the artifacts
943943
- [ ] If icon missing: asked user to provide SVG
944944
- [ ] If triggers exist: `triggers` config set, trigger subBlocks spread
945945
- [ ] Optional/rarely-used fields set to `mode: 'advanced'`

.agents/skills/add-integration/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ bun run tool-metadata:generate
422422
```
423423

424424
Client code reads `params`/`outputs` from these artifacts rather than importing
425-
the registry, so a new tool is invisible to the UI until they are regenerated,
425+
the registry, so a tool you add, change or remove is invisible to the UI until they are regenerated,
426426
and CI fails on stale ones. See `.agents/skills/tool-registry-boundary/SKILL.md`.
427427

428428
### Block Registry (`apps/sim/blocks/registry-maps.ts`)

.agents/skills/add-tools/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ bun run tool-metadata:generate
303303
```
304304

305305
Client code reads a tool's `params`/`outputs` from generated metadata rather than
306-
importing the registry, so a new or changed tool is invisible to the UI until
306+
importing the registry, so a tool you add, change or remove is invisible to the UI until
307307
these are regenerated — and CI fails on stale artifacts. Commit the result. See
308308
`.agents/skills/tool-registry-boundary/SKILL.md`.
309309

.claude/commands/add-block.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ Derive templates from the service's real use cases. Each prompt should name a co
922922

923923
Adding a block on its own needs **no** regeneration — a block references existing tool IDs through `tools.access` and does not change any tool's shape.
924924

925-
But if the same change also adds or edits a tool, run `bun run tool-metadata:generate` and commit the result, or CI fails on stale artifacts. That matters here because a block's `outputs` are authored to match its tools' outputs, and the UI now reads those from the generated metadata rather than the executable registry — an unregenerated tool change makes the block's outputs disagree with what the panel renders. See `.agents/skills/tool-registry-boundary/SKILL.md`.
925+
But if the same change also adds, edits **or removes** a tool, run `bun run tool-metadata:generate` and commit the result, or CI fails on stale artifacts. That matters here because a block's `outputs` are authored to match its tools' outputs, and the UI now reads those from the generated metadata rather than the executable registry — an unregenerated tool change makes the block's outputs disagree with what the panel renders. See `.agents/skills/tool-registry-boundary/SKILL.md`.
926926

927927
## Checklist Before Finishing
928928

@@ -938,7 +938,7 @@ But if the same change also adds or edits a tool, run `bun run tool-metadata:gen
938938
- [ ] Tools.config.tool returns correct tool ID (snake_case)
939939
- [ ] Outputs match tool outputs
940940
- [ ] Block + meta registered in registry-maps.ts (`BLOCK_REGISTRY` / `BLOCK_META_REGISTRY`)
941-
- [ ] If any tool was added or changed alongside the block: ran `bun run tool-metadata:generate` and committed the artifacts
941+
- [ ] If any tool was added, changed or removed alongside the block: ran `bun run tool-metadata:generate` and committed the artifacts
942942
- [ ] If icon missing: asked user to provide SVG
943943
- [ ] If triggers exist: `triggers` config set, trigger subBlocks spread
944944
- [ ] Optional/rarely-used fields set to `mode: 'advanced'`

.claude/commands/add-integration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ bun run tool-metadata:generate
421421
```
422422

423423
Client code reads `params`/`outputs` from these artifacts rather than importing
424-
the registry, so a new tool is invisible to the UI until they are regenerated,
424+
the registry, so a tool you add, change or remove is invisible to the UI until they are regenerated,
425425
and CI fails on stale ones. See `.agents/skills/tool-registry-boundary/SKILL.md`.
426426

427427
### Block Registry (`apps/sim/blocks/registry-maps.ts`)

.claude/commands/add-tools.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ bun run tool-metadata:generate
302302
```
303303

304304
Client code reads a tool's `params`/`outputs` from generated metadata rather than
305-
importing the registry, so a new or changed tool is invisible to the UI until
305+
importing the registry, so a tool you add, change or remove is invisible to the UI until
306306
these are regenerated — and CI fails on stale artifacts. Commit the result. See
307307
`.agents/skills/tool-registry-boundary/SKILL.md`.
308308

.cursor/commands/add-block.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,7 @@ Derive templates from the service's real use cases. Each prompt should name a co
917917

918918
Adding a block on its own needs **no** regeneration — a block references existing tool IDs through `tools.access` and does not change any tool's shape.
919919

920-
But if the same change also adds or edits a tool, run `bun run tool-metadata:generate` and commit the result, or CI fails on stale artifacts. That matters here because a block's `outputs` are authored to match its tools' outputs, and the UI now reads those from the generated metadata rather than the executable registry — an unregenerated tool change makes the block's outputs disagree with what the panel renders. See `.agents/skills/tool-registry-boundary/SKILL.md`.
920+
But if the same change also adds, edits **or removes** a tool, run `bun run tool-metadata:generate` and commit the result, or CI fails on stale artifacts. That matters here because a block's `outputs` are authored to match its tools' outputs, and the UI now reads those from the generated metadata rather than the executable registry — an unregenerated tool change makes the block's outputs disagree with what the panel renders. See `.agents/skills/tool-registry-boundary/SKILL.md`.
921921

922922
## Checklist Before Finishing
923923

@@ -933,7 +933,7 @@ But if the same change also adds or edits a tool, run `bun run tool-metadata:gen
933933
- [ ] Tools.config.tool returns correct tool ID (snake_case)
934934
- [ ] Outputs match tool outputs
935935
- [ ] Block + meta registered in registry-maps.ts (`BLOCK_REGISTRY` / `BLOCK_META_REGISTRY`)
936-
- [ ] If any tool was added or changed alongside the block: ran `bun run tool-metadata:generate` and committed the artifacts
936+
- [ ] If any tool was added, changed or removed alongside the block: ran `bun run tool-metadata:generate` and committed the artifacts
937937
- [ ] If icon missing: asked user to provide SVG
938938
- [ ] If triggers exist: `triggers` config set, trigger subBlocks spread
939939
- [ ] Optional/rarely-used fields set to `mode: 'advanced'`

.cursor/commands/add-integration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ bun run tool-metadata:generate
416416
```
417417

418418
Client code reads `params`/`outputs` from these artifacts rather than importing
419-
the registry, so a new tool is invisible to the UI until they are regenerated,
419+
the registry, so a tool you add, change or remove is invisible to the UI until they are regenerated,
420420
and CI fails on stale ones. See `.agents/skills/tool-registry-boundary/SKILL.md`.
421421

422422
### Block Registry (`apps/sim/blocks/registry-maps.ts`)

.cursor/commands/add-tools.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ bun run tool-metadata:generate
297297
```
298298

299299
Client code reads a tool's `params`/`outputs` from generated metadata rather than
300-
importing the registry, so a new or changed tool is invisible to the UI until
300+
importing the registry, so a tool you add, change or remove is invisible to the UI until
301301
these are regenerated — and CI fails on stale artifacts. Commit the result. See
302302
`.agents/skills/tool-registry-boundary/SKILL.md`.
303303

0 commit comments

Comments
 (0)