Skip to content

Commit 3ac64f2

Browse files
waleedlatif1waleedlatif1
committed
perf(tools): move mergeToolParameters into a registry-free leaf module
`providers/utils.ts` imports exactly one thing from `@/tools/params`: `mergeToolParameters`. That function performs no tool lookup at all — it merges two plain param objects. But `params.ts` imports `getTool` from `@/tools/utils`, which statically imports the 4,300-entry `@/tools/registry` barrel, so that one-symbol import was dragging the entire tool registry into every module graph that reached it. Measured with a module-graph walk from each entry: tools/params.ts 4,926 modules (registry reachable) providers/utils.ts 4,926 modules (registry reachable) -> 22 modules ✅ tools/merge-params.ts 2 modules (registry NOT reachable) `mergeToolParameters`, `deepMergeInputMapping` and `isNonEmpty` move to `@/tools/merge-params`, which is forbidden from importing `@/tools/utils`, `@/tools/registry` or `@/tools/params`. `params.ts` now imports `isNonEmpty` from there; its `isRecordLike` and `isEmptyTagValue` imports became unused and are dropped. The two consumers (`providers/utils.ts`, `executor/handlers/pi/sim-tools.ts`) import from the new module directly rather than via a re-export, per the no-re-exports rule. This is preparation, not the payoff. The canvas route still reaches the registry through three other edges (block-outputs, serializer, sanitization/validation) — all four are redundant paths and must all be cut before the route's module count moves. Those follow in the metadata-manifest PRs. Behaviour is unchanged: the moved functions are copied verbatim.
1 parent 4aa07e5 commit 3ac64f2

5 files changed

Lines changed: 124 additions & 110 deletions

File tree

‎apps/sim/executor/handlers/pi/sim-tools.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import type { PiToolResult, PiToolSpec } from '@/executor/handlers/pi/backend'
1616
import type { ExecutionContext } from '@/executor/types'
1717
import { transformBlockTool } from '@/providers/utils'
1818
import { executeTool } from '@/tools'
19-
import { mergeToolParameters } from '@/tools/params'
19+
import { mergeToolParameters } from '@/tools/merge-params'
2020
import type { ToolResponse } from '@/tools/types'
2121
import { getTool } from '@/tools/utils'
2222
import { getToolAsync } from '@/tools/utils.server'

‎apps/sim/providers/utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ import {
5151
} from '@/providers/models'
5252
import type { ProviderId, ProviderToolConfig } from '@/providers/types'
5353
import { useProvidersStore } from '@/stores/providers/store'
54-
import { mergeToolParameters } from '@/tools/params'
54+
import { mergeToolParameters } from '@/tools/merge-params'
5555

5656
const logger = createLogger('ProviderUtils')
5757

‎apps/sim/tools/merge-params.ts‎

Lines changed: 120 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
import { isRecordLike } from '@sim/utils/object'
2+
import { isEmptyTagValue } from '@/tools/shared/tags'
3+
4+
/**
5+
* Merging of user-provided and LLM-generated tool parameters.
6+
*
7+
* Deliberately kept in its own leaf module rather than in `@/tools/params`.
8+
* `params.ts` imports `getTool` from `@/tools/utils`, which statically imports
9+
* the 4,300-entry `@/tools/registry` barrel — so importing anything from
10+
* `params.ts` drags the whole tool registry into the caller's module graph
11+
* (4,926 modules, versus 17 without that edge).
12+
*
13+
* `providers/utils.ts` needs only `mergeToolParameters`, and this function needs
14+
* no tool lookup at all, so it lives here and that import edge stays cheap.
15+
* Nothing in this file may import `@/tools/utils`, `@/tools/registry`, or
16+
* `@/tools/params`.
17+
*/
18+
19+
/** Checks if a value is non-empty (not undefined, null, or empty string). */
20+
export function isNonEmpty(value: unknown): boolean {
21+
return value !== undefined && value !== null && value !== ''
22+
}
23+
24+
/**
25+
* Deep merges inputMapping objects, where LLM values fill in empty/missing user values.
26+
* User-provided non-empty values take precedence.
27+
*/
28+
export function deepMergeInputMapping(
29+
llmInputMapping: Record<string, unknown> | undefined,
30+
userInputMapping: Record<string, unknown> | string | undefined
31+
): Record<string, unknown> {
32+
// Parse user inputMapping if it's a JSON string
33+
let parsedUserMapping: Record<string, unknown> = {}
34+
if (typeof userInputMapping === 'string') {
35+
try {
36+
const parsed = JSON.parse(userInputMapping)
37+
if (isRecordLike(parsed)) {
38+
parsedUserMapping = parsed
39+
}
40+
} catch {
41+
// Invalid JSON, treat as empty
42+
}
43+
} else if (
44+
typeof userInputMapping === 'object' &&
45+
userInputMapping !== null &&
46+
!Array.isArray(userInputMapping)
47+
) {
48+
parsedUserMapping = userInputMapping
49+
}
50+
51+
// If no LLM mapping, return user mapping (or empty)
52+
if (!llmInputMapping || typeof llmInputMapping !== 'object') {
53+
return parsedUserMapping
54+
}
55+
56+
// Deep merge: LLM values as base, user non-empty values override
57+
// If user provides empty object {}, LLM values fill all fields (intentional)
58+
const merged: Record<string, unknown> = { ...llmInputMapping }
59+
60+
for (const [key, userValue] of Object.entries(parsedUserMapping)) {
61+
// Only override LLM value if user provided a non-empty value
62+
if (isNonEmpty(userValue)) {
63+
merged[key] = userValue
64+
}
65+
}
66+
67+
return merged
68+
}
69+
70+
/**
71+
* Merges user-provided parameters with LLM-generated parameters.
72+
* User-provided parameters take precedence, but empty strings are skipped
73+
* so that LLM-generated values are used when user clears a field.
74+
*
75+
* Special handling for inputMapping: deep merges so LLM can fill in
76+
* fields that user left empty in the UI.
77+
*/
78+
export function mergeToolParameters(
79+
userProvidedParams: Record<string, unknown>,
80+
llmGeneratedParams: Record<string, unknown>
81+
): Record<string, unknown> {
82+
// Filter out empty and effectively-empty values from user-provided params
83+
// so that cleared fields don't override LLM values
84+
const filteredUserParams: Record<string, unknown> = {}
85+
for (const [key, value] of Object.entries(userProvidedParams)) {
86+
if (isNonEmpty(value)) {
87+
// Skip tag-based params if they're effectively empty (only default/unfilled entries)
88+
if ((key === 'documentTags' || key === 'tagFilters') && isEmptyTagValue(value)) {
89+
continue
90+
}
91+
filteredUserParams[key] = value
92+
}
93+
}
94+
95+
// Start with LLM params as base
96+
const result: Record<string, unknown> = { ...llmGeneratedParams }
97+
98+
// Apply user params, with special handling for inputMapping
99+
for (const [key, userValue] of Object.entries(filteredUserParams)) {
100+
if (key === 'inputMapping') {
101+
// Deep merge inputMapping so LLM values fill in empty user fields
102+
const llmInputMapping = llmGeneratedParams.inputMapping as Record<string, unknown> | undefined
103+
const mergedInputMapping = deepMergeInputMapping(
104+
llmInputMapping,
105+
userValue as Record<string, unknown> | string | undefined
106+
)
107+
result.inputMapping = mergedInputMapping
108+
} else {
109+
// Normal override for other params
110+
result[key] = userValue
111+
}
112+
}
113+
114+
// If LLM provided inputMapping but user didn't, ensure it's included
115+
if (llmGeneratedParams.inputMapping && !filteredUserParams.inputMapping) {
116+
result.inputMapping = llmGeneratedParams.inputMapping
117+
}
118+
119+
return result
120+
}

‎apps/sim/tools/params.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { afterAll, describe, expect, it, vi } from 'vitest'
2+
import { mergeToolParameters } from '@/tools/merge-params'
23
import {
34
createExecutionToolSchema,
45
createLLMToolSchema,
@@ -8,7 +9,6 @@ import {
89
getSubBlocksForToolInput,
910
getToolParametersConfig,
1011
isPasswordParameter,
11-
mergeToolParameters,
1212
type ToolParameterConfig,
1313
type ToolSchema,
1414
type ValidationResult,

‎apps/sim/tools/params.ts‎

Lines changed: 1 addition & 107 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { createLogger } from '@sim/logger'
2-
import { isRecordLike } from '@sim/utils/object'
32
import { extractInputFieldsFromBlocks } from '@/lib/workflows/input-format'
43
import {
54
buildCanonicalIndex,
@@ -18,8 +17,8 @@ import type {
1817
SubBlockConfig as BlockSubBlockConfig,
1918
GenerationType,
2019
} from '@/blocks/types'
20+
import { isNonEmpty } from '@/tools/merge-params'
2121
import { safeAssign } from '@/tools/safe-assign'
22-
import { isEmptyTagValue } from '@/tools/shared/tags'
2322
import type {
2423
OAuthConfig,
2524
ParameterVisibility,
@@ -31,13 +30,6 @@ import { getTool } from '@/tools/utils'
3130
const logger = createLogger('ToolsParams')
3231
type ToolParamDefinition = ToolConfig['params'][string]
3332

34-
/**
35-
* Checks if a value is non-empty (not undefined, null, or empty string)
36-
*/
37-
export function isNonEmpty(value: unknown): boolean {
38-
return value !== undefined && value !== null && value !== ''
39-
}
40-
4133
// ============================================================================
4234
// Tag/Value Parsing Utilities
4335
// ============================================================================
@@ -827,104 +819,6 @@ export function createExecutionToolSchema(toolConfig: ToolConfig): ToolSchema {
827819
return schema
828820
}
829821

830-
/**
831-
* Deep merges inputMapping objects, where LLM values fill in empty/missing user values.
832-
* User-provided non-empty values take precedence.
833-
*/
834-
export function deepMergeInputMapping(
835-
llmInputMapping: Record<string, unknown> | undefined,
836-
userInputMapping: Record<string, unknown> | string | undefined
837-
): Record<string, unknown> {
838-
// Parse user inputMapping if it's a JSON string
839-
let parsedUserMapping: Record<string, unknown> = {}
840-
if (typeof userInputMapping === 'string') {
841-
try {
842-
const parsed = JSON.parse(userInputMapping)
843-
if (isRecordLike(parsed)) {
844-
parsedUserMapping = parsed
845-
}
846-
} catch {
847-
// Invalid JSON, treat as empty
848-
}
849-
} else if (
850-
typeof userInputMapping === 'object' &&
851-
userInputMapping !== null &&
852-
!Array.isArray(userInputMapping)
853-
) {
854-
parsedUserMapping = userInputMapping
855-
}
856-
857-
// If no LLM mapping, return user mapping (or empty)
858-
if (!llmInputMapping || typeof llmInputMapping !== 'object') {
859-
return parsedUserMapping
860-
}
861-
862-
// Deep merge: LLM values as base, user non-empty values override
863-
// If user provides empty object {}, LLM values fill all fields (intentional)
864-
const merged: Record<string, unknown> = { ...llmInputMapping }
865-
866-
for (const [key, userValue] of Object.entries(parsedUserMapping)) {
867-
// Only override LLM value if user provided a non-empty value
868-
if (isNonEmpty(userValue)) {
869-
merged[key] = userValue
870-
}
871-
}
872-
873-
return merged
874-
}
875-
876-
/**
877-
* Merges user-provided parameters with LLM-generated parameters.
878-
* User-provided parameters take precedence, but empty strings are skipped
879-
* so that LLM-generated values are used when user clears a field.
880-
*
881-
* Special handling for inputMapping: deep merges so LLM can fill in
882-
* fields that user left empty in the UI.
883-
*/
884-
export function mergeToolParameters(
885-
userProvidedParams: Record<string, unknown>,
886-
llmGeneratedParams: Record<string, unknown>
887-
): Record<string, unknown> {
888-
// Filter out empty and effectively-empty values from user-provided params
889-
// so that cleared fields don't override LLM values
890-
const filteredUserParams: Record<string, unknown> = {}
891-
for (const [key, value] of Object.entries(userProvidedParams)) {
892-
if (isNonEmpty(value)) {
893-
// Skip tag-based params if they're effectively empty (only default/unfilled entries)
894-
if ((key === 'documentTags' || key === 'tagFilters') && isEmptyTagValue(value)) {
895-
continue
896-
}
897-
filteredUserParams[key] = value
898-
}
899-
}
900-
901-
// Start with LLM params as base
902-
const result: Record<string, unknown> = { ...llmGeneratedParams }
903-
904-
// Apply user params, with special handling for inputMapping
905-
for (const [key, userValue] of Object.entries(filteredUserParams)) {
906-
if (key === 'inputMapping') {
907-
// Deep merge inputMapping so LLM values fill in empty user fields
908-
const llmInputMapping = llmGeneratedParams.inputMapping as Record<string, unknown> | undefined
909-
const mergedInputMapping = deepMergeInputMapping(
910-
llmInputMapping,
911-
userValue as Record<string, unknown> | string | undefined
912-
)
913-
result.inputMapping = mergedInputMapping
914-
} else {
915-
// Normal override for other params
916-
result[key] = userValue
917-
}
918-
}
919-
920-
// If LLM provided inputMapping but user didn't, ensure it's included
921-
if (llmGeneratedParams.inputMapping && !filteredUserParams.inputMapping) {
922-
result.inputMapping = llmGeneratedParams.inputMapping
923-
}
924-
925-
return result
926-
}
927-
928822
/**
929823
* Filters out user-provided parameters from tool schema for LLM
930824
*/

0 commit comments

Comments
 (0)