improvement(search): use standard source row navigation

Author: waleedlatif1

apps/sim/app/o/[organizationId]/settings/components/integrations/organization-integrations-setup.tsx

@@ -2,7 +2,6 @@
 
 import { useMemo, useState } from 'react'
 import { Chip, ChipConfirmModal, ChipModalError, Switch } from '@sim/emcn'
-import { useRouter } from 'next/navigation'
 import { useQueryState } from 'nuqs'
 import { SettingsPanel } from '@/components/settings/settings-panel'
 import type { ResourceScope } from '@/lib/core/resource-scope'
@@ -66,7 +65,6 @@ export function OrganizationIntegrationsSetup() {
     searchSetupParam.key,
     searchSetupParam.parser.withOptions({ history: 'replace' })
   )
-  const router = useRouter()
   const membershipQueryKeys = useMemo(
     () => [searchSourceKeys.list({ kind: 'organization', organizationId: organization.id })],
     [organization.id]
@@ -210,11 +208,9 @@ export function OrganizationIntegrationsSetup() {
                     waiting={enrollment.isAwaiting(source.connectorId)}
                     isPending={enrollment.isPending}
                     onConnect={() => enrollment.connect(source.knowledgeBaseId, source.connectorId)}
-                    onManage={() =>
-                      router.push(
-                        organizationRoutes(organization.id).searchSource(source.connectorId)
-                      )
-                    }
+                    manageHref={organizationRoutes(organization.id).searchSource(
+                      source.connectorId
+                    )}
                   />
                 ))}
               </div>

apps/sim/app/workspace/[workspaceId]/search/components/search-source-row.test.tsx

@@ -38,7 +38,13 @@ function source(overrides: Partial<SearchSourceSummary> = {}): SearchSourceSumma
 
 async function render(
   data = source(),
-  props: { canAdmin?: boolean; available?: boolean; waiting?: boolean; isPending?: boolean } = {}
+  props: {
+    canAdmin?: boolean
+    available?: boolean
+    waiting?: boolean
+    isPending?: boolean
+    manageHref?: string
+  } = {}
 ) {
   await act(async () =>
     root.render(
@@ -185,6 +191,29 @@ describe('Search source viewer actions', () => {
     expect(connect).not.toHaveBeenCalled()
   })
 
+  it('opens source details through a row link while preserving the separate connection action', async () => {
+    const manageHref = '/o/org-1/settings/integrations/sources/source-1'
+    await render(source(), { canAdmin: true, manageHref })
+    const link = container.querySelector('a')
+    expect(link?.getAttribute('href')).toBe(manageHref)
+    expect(link?.getAttribute('aria-label')).toBe('Open engineering.atlassian.net · ENG')
+    expect(button('Manage')).toBeUndefined()
+    expect(button('Confluence source actions')).toBeUndefined()
+    expect(link?.contains(button('Connect account')!)).toBe(false)
+    await act(async () => button('Connect account')!.click())
+    expect(connect).toHaveBeenCalledOnce()
+    expect(manage).not.toHaveBeenCalled()
+  })
+
+  it('does not expose management navigation to a non-admin', async () => {
+    await render(source(), {
+      canAdmin: false,
+      manageHref: '/o/org-1/settings/integrations/sources/source-1',
+    })
+    expect(container.querySelector('a')).toBeNull()
+    expect(button('Connect account')).toBeDefined()
+  })
+
   it.each([false, true])(
     'retains the legacy knowledge-base link for canAdmin=%s',
     async (canAdmin) => {

apps/sim/app/workspace/[workspaceId]/search/components/search-source-row.tsx

@@ -19,6 +19,7 @@ interface SearchSourceRowProps {
   waiting: boolean
   isPending: boolean
   onConnect: () => void
+  manageHref?: string
   /** Opens management for the source; only a surface that offers management passes it. */
   onManage?: () => void
 }
@@ -33,6 +34,7 @@ export function SearchSourceRow({
   waiting,
   isPending,
   onConnect,
+  manageHref,
   onManage,
 }: SearchSourceRowProps) {
   const scope = explicitScope ?? resourceScopeFromOwner({ workspaceId })
@@ -41,6 +43,7 @@ export function SearchSourceRow({
   const membership = source.viewerMembership
   const usable = available && source.availability === 'available'
   const supported = meta?.search === true
+  const managementHref = canAdmin ? manageHref : undefined
   const connectable =
     usable &&
     supported &&
@@ -86,6 +89,9 @@ export function SearchSourceRow({
       }
       title={name}
       description={[source.sourceDescription, status].filter(Boolean).join(' · ')}
+      href={managementHref}
+      clickLabel={managementHref ? `Open ${source.sourceDescription || name}` : undefined}
+      navigable={Boolean(managementHref)}
       trailing={
         !supported && scope.kind === 'workspace' ? (
           <ChipLink href={`/workspace/${scope.workspaceId}/knowledge/${source.knowledgeBaseId}`}>
@@ -103,6 +109,7 @@ export function SearchSourceRow({
               </Chip>
             )}
             {canAdmin &&
+              !managementHref &&
               onManage &&
               (connectable ? (
                 <RowActionsMenu