Skip to content

Use targetRefs and sourceRefs instead of refs in pre-translations#297

Merged
pmachapman merged 1 commit into
mainfrom
source_refs
May 20, 2026
Merged

Use targetRefs and sourceRefs instead of refs in pre-translations#297
pmachapman merged 1 commit into
mainfrom
source_refs

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented May 14, 2026

This PR removes support for the old refs property for pre-translations, and instead supports sourceRefs and targetRefs.

Partial fix for sillsdev/serval#940.


This change is Reviewable

Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enkidu93 reviewed 6 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.53%. Comparing base (29d4dbb) to head (72b3d37).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         355      355           
  Lines       23026    23028    +2     
=======================================
+ Hits        21077    21079    +2     
  Misses       1949     1949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pmachapman pmachapman merged commit e245623 into main May 20, 2026
14 checks passed
@pmachapman pmachapman deleted the source_refs branch May 20, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants