TT-7300 Mark Verses highlighting & Edit Reference (#314)#322
Open
gtryus wants to merge 3 commits into
Open
Conversation
gtryus
changed the title
gtryus
changed the title
added 3 commits
May 22, 2026 16:14
- Improved segment matching logic in usePlayerLogic for better accuracy. - Updated WSAudioPlayer to support new markVersesTailOpenRef prop for managing verse states. - Enhanced PassageDetailMarkVerses to handle incomplete verse rows and apply region colors dynamically. - Refactored EditReferenceDropdown to manage end verse options and suffix handling more effectively. - Improved MarkVersesTableIsMobile to allow for better interaction and visual feedback based on segment states. - Added tests to ensure correct behavior of new features and UI changes.
- Updated existing test to verify that the reference input is not read-only when editable. - Added new test to ensure the reference input remains read-only and disabled when the row lacks timestamps. - Improved interaction feedback for better user experience in mobile view.
- Add segment while playing should not stop playing - Marking verses should autosave (remove Save button) - After adding segment, you have to tap Play twice to resume - Related: The design shows that the succeeding segment should be selected after adding, not the preceding. This was a specific request from you, so I'm wondering if you're unaware that this is not working? - The rows should not be editable. Please also remove the textfield-style underline for the Reference cells. I do see some merit to this for the desktop, but on mobile devices, showing the keyboard every tap is very distracting. (I did not run this local branch on my mobile device.) - The rows should be in a scrollable area, not the whole page. Moving to a scrollable table will reduce the scrollable space, so you'll at that point really need to focus on minimizing the vertical space consumed by the rest of the page. For example, the Plus/Minus row consumes a lot of height. Same for the Play/Duration row. - After you do this comment, the next important thing to do is to scroll to the row when selecting a segment in the waveform. (Right now it's a little frustrating that all the later rows are highlighted offscreen.) - The Edit Reference doesn't appear to support spanning chapters. This was a request during the design phase. Maybe it's not MVP? - The Edit Reference dropdown numbers look really large. Maybe Jiho can help with general styling and spacing these new pages. - When deleting a boundary, the waveform and table highlights get out of sync, and it appears to select the segment after where the cursor is. - I like the way the Minus button works with segment selection, even though it doesn't match the design. - Undo seems broken. It's more of a question in the design whether or not we need it, but in its current state it is not very useful. - Undo seems to undo more than the previous action. - Undo seems to not appear many times, e.g. add, delete, etc. - Undo also seems to disappear after one undo operation. Is it just saving the most recent action? It's pretty difficult to test in its current state. - Save navigates away from the page? It appears to also do a Step Complete, which should not be happening either. These issues should go away if you can accomplish autosave for this step. - I'm not really sure how to mark something as just a partial verse, e.g. 1:11a. This may be a flaw in the design. Do you know how to do this in the app? (other than manual entry in the row) - Reset does not remove the table row highlight (visual quirk) - Reset is not recoverable. Either do a confirmation dialog or make it undo-able.
gtryus
force-pushed
the
TT-7300-mark-vrs-hilite
branch
from
3cbb0fc to
26e9b76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Mark Verses on mobile and desktop so the waveform, table, and Edit Reference dialog stay aligned with the wireframes and behave correctly for partial marking, reference editing, and navigation.