Skip to content

Commit 1d7d4c9

Browse files
committed
Fixes
1 parent b26b907 commit 1d7d4c9

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,15 @@ jobs:
3737
with:
3838
dotnet-version: '10.0.x'
3939

40-
# build.slnf leaves out Sample.Maui - the MAUI head needs the workloads installed and proves
41-
# nothing the other samples do not already prove about the library itself.
4240
- name: Build
4341
run: dotnet build build.slnf /restore -m -property:Configuration=Release -property:PublicRelease=true
4442

43+
# No --no-build: build.slnf deliberately excludes the test project, so the previous step never
44+
# produced its output. xunit v3 runs on Microsoft.Testing.Platform, so trx comes from
45+
# --report-trx (the VSTest "--logger trx" spelling is silently ignored here).
4546
- name: Test
46-
run: dotnet test tests/Shiny.Net.HttpServer.Tests/Shiny.Net.HttpServer.Tests.csproj --configuration Release --no-build --logger "trx;LogFileName=test-results.trx"
47+
run: dotnet test tests/Shiny.Net.HttpServer.Tests/Shiny.Net.HttpServer.Tests.csproj --configuration Release -- --report-trx --report-trx-filename test-results.trx
4748

48-
# Runs the real ILC compiler over the library. Catches trim/AOT breaks the Roslyn analyzers cannot
49-
# see - warnings out of dependencies, and anything only reachable through a call graph.
5049
- name: Verify Native AOT
5150
run: dotnet publish samples/Sample.Api/Sample.Api.csproj -r osx-arm64 --configuration Release
5251

‎Directory.Packages.props‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747
<ItemGroup>
4848
<PackageVersion Include="xunit.v3" Version="3.1.0"/>
4949
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.0.0"/>
50+
<!-- Keep in lockstep with the Microsoft.Testing.Platform version xunit.v3 resolves (1.8.4). -->
51+
<PackageVersion Include="Microsoft.Testing.Extensions.TrxReport" Version="1.8.4"/>
5052
</ItemGroup>
5153

5254
</Project>

‎tests/Shiny.Net.HttpServer.Tests/Shiny.Net.HttpServer.Tests.csproj‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515

1616
<ItemGroup>
1717
<PackageReference Include="xunit.v3" />
18+
19+
<!-- MTP has no built-in trx writer; the report-trx option CI passes comes from this extension. -->
20+
<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" />
21+
1822
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
1923
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
2024

0 commit comments

Comments
 (0)