CRY-58: fix(linear): normalize malformed responses in User.Read.ByTeam (#147)

## Summary

Fixes a defensive-coding gap in `User.Read.ByTeam` where malformed or
partially-populated API responses could leak a bare map out of the
`else`
clause instead of returning a proper `{:ok, []}` or `{:error, _}` tuple.

- Replace the two-step `with` match (extract team, then match members)
with a
  single deep pattern match, consistent with `Label.Read.ByTeam`,
  `WorkflowState.Read.ByTeam`, and `Project.Read.ByTeam`.
- The `else` catch-all `{:ok, _} -> {:ok, []}` now correctly handles
null
  team, missing `members` key, and missing `nodes` key as graceful empty
  results.
- Add 5 new tests covering: valid response, null team, missing members
key,
  missing nodes key, and API error propagation.

Closes CRY-58.

## Test plan

- [x] `mix test test/linear_cli/linear/user_test.exs` — all 6 tests pass
- [x] `mix compile --warnings-as-errors` — clean
- [x] `mix test` — 260/267 pass; 7 failures are pre-existing `GitTest`
environment failures unrelated to this change

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: bougyman

app/lib/linear_cli/linear/user.ex

@@ -74,8 +74,8 @@ defmodule LinearCli.Linear.User.Read.ByTeam do
     document =
       "query($id: String!) { team(id: $id) { members(first: 50) { nodes { #{User.base_fields()} } } } }"
 
-    with {:ok, %{"team" => team}} when is_map(team) <- Api.call(document, %{"id" => team_id}),
-         %{"members" => %{"nodes" => nodes}} <- team do
+    with {:ok, %{"team" => %{"members" => %{"nodes" => nodes}}}} <-
+           Api.call(document, %{"id" => team_id}) do
       {:ok, Enum.map(nodes, &User.from_map/1)}
     else
       {:ok, _} -> {:ok, []}

app/test/linear_cli/linear/user_test.exs

@@ -3,6 +3,58 @@ defmodule LinearCli.Linear.UserTest do
 
   alias LinearCli.Linear
 
+  test "team_members/1 returns a list of users for a valid team response" do
+    Req.Test.stub(LinearCli.Api, fn conn ->
+      Req.Test.json(conn, %{
+        "data" => %{
+          "team" => %{
+            "members" => %{
+              "nodes" => [
+                %{"id" => "u1", "name" => "Alice", "email" => "alice@example.com"},
+                %{"id" => "u2", "name" => "Bob", "email" => "bob@example.com"}
+              ]
+            }
+          }
+        }
+      })
+    end)
+
+    assert {:ok, [%Linear.User{id: "u1", name: "Alice"}, %Linear.User{id: "u2", name: "Bob"}]} =
+             Linear.team_members("t1")
+  end
+
+  test "team_members/1 returns an empty list when team is null" do
+    Req.Test.stub(LinearCli.Api, fn conn ->
+      Req.Test.json(conn, %{"data" => %{"team" => nil}})
+    end)
+
+    assert {:ok, []} = Linear.team_members("nonexistent")
+  end
+
+  test "team_members/1 returns an empty list when members key is absent" do
+    Req.Test.stub(LinearCli.Api, fn conn ->
+      Req.Test.json(conn, %{"data" => %{"team" => %{}}})
+    end)
+
+    assert {:ok, []} = Linear.team_members("t1")
+  end
+
+  test "team_members/1 returns an empty list when nodes key is absent" do
+    Req.Test.stub(LinearCli.Api, fn conn ->
+      Req.Test.json(conn, %{"data" => %{"team" => %{"members" => %{}}}})
+    end)
+
+    assert {:ok, []} = Linear.team_members("t1")
+  end
+
+  test "team_members/1 propagates API errors" do
+    Req.Test.stub(LinearCli.Api, fn conn ->
+      Req.Test.json(conn, %{"errors" => [%{"message" => "Unauthorized"}]})
+    end)
+
+    assert {:error, %Ash.Error.Unknown{}} = Linear.team_members("t1")
+  end
+
   test "me/0 decodes the viewer, including nested teams" do
     Req.Test.stub(LinearCli.Api, fn conn ->
       Req.Test.json(conn, %{