Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

CMD + Click on a definition should show the best match first #857

Description

@davidalejandroaguilar

Your environment

  • vscode-ruby version: 0.28.1
  • Ruby version: 3.1.2
  • Ruby version manager (if any): asdf
  • VS Code version: 1.76.2
  • Operating System: Mac OS Monterrey 12.6
  • Using language server? (eg useLanguageServer is true in your configuration?) Yes (rubyLocate)

Expected behavior

CMD + Click on a definition should either:

  • Show the best match first.
  • Show the best match outside the suggestions panel for a quick click.

Solargraph

Solargraph does the right thing, but unfortunately, clicking it takes you to the literal definition, not to the actual code.

Example:

Screen.Recording.2023-03-31.at.1.46.01.a.m.mov

Actual behavior

CMD + Click on User::CreateOperation shows 3 definitions on the Intellisense pane.

For example:

  • Admin::CreateOperation
  • Employee::CreateOperation (this one shown on the details pane)
  • User::CreateOperation

Real example:

Screen.Recording.2023-03-31.at.1.17.58.a.m.mov

I then have to search this pane for User::CreateOperation instead of it being at the top.


Not familiar with the codebase but let me know how I can help.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions