Remove newArchEnabled from root view factory initializers (#58488)

Summary:

Remove the unused `newArchEnabled` parameter from `RCTRootViewFactoryConfiguration` initializers and update callers.

Changelog:
[iOS][Breaking] - Remove `newArchEnabled` from `RCTRootViewFactoryConfiguration` initializers; use `initWithBundleURL:` or `initWithBundleURLBlock:` instead

Differential Revision: D119673104

Author: christophpurrer

packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.mm

@@ -289,7 +289,7 @@ - (RCTRootViewFactory *)createRCTRootViewFactory
   };
 
   RCTRootViewFactoryConfiguration *configuration =
-      [[RCTRootViewFactoryConfiguration alloc] initWithBundleURLBlock:bundleUrlBlock newArchEnabled:YES];
+      [[RCTRootViewFactoryConfiguration alloc] initWithBundleURLBlock:bundleUrlBlock];
 
   configuration.customizeRootView = ^(UIView *_Nonnull rootView) {
     [weakSelf.delegate customizeRootView:(RCTRootView *)rootView];

packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.h

@@ -55,10 +55,9 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
  * pointing to a path inside the app resources, e.g. `file://.../main.jsbundle`.
  *
  */
-- (instancetype)initWithBundleURLBlock:(RCTBundleURLBlock)bundleURLBlock
-                        newArchEnabled:(BOOL)newArchEnabled NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithBundleURLBlock:(RCTBundleURLBlock)bundleURLBlock NS_DESIGNATED_INITIALIZER;
 
-- (instancetype)initWithBundleURL:(NSURL *)bundleURL newArchEnabled:(BOOL)newArchEnabled;
+- (instancetype)initWithBundleURL:(NSURL *)bundleURL;
 
 /**
  * Block that allows to override logic of creating root view instance.

packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm

@@ -32,16 +32,6 @@
 
 @implementation RCTRootViewFactoryConfiguration
 
-- (instancetype)initWithBundleURL:(NSURL *)bundleURL newArchEnabled:(BOOL)newArchEnabled
-{
-  return [self initWithBundleURL:bundleURL];
-}
-
-- (instancetype)initWithBundleURLBlock:(RCTBundleURLBlock)bundleURLBlock newArchEnabled:(BOOL)newArchEnabled
-{
-  return [self initWithBundleURLBlock:bundleURLBlock];
-}
-
 - (instancetype)initWithBundleURLBlock:(RCTBundleURLBlock)bundleURLBlock
 {
   if (self = [super init]) {

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -1694,8 +1694,8 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;
-  public virtual instancetype initWithBundleURL:newArchEnabled:(NSURL* bundleURL, BOOL newArchEnabled);
-  public virtual instancetype initWithBundleURLBlock:newArchEnabled:(RCTBundleURLBlock bundleURLBlock, BOOL newArchEnabled);
+  public virtual instancetype initWithBundleURL:(NSURL* bundleURL);
+  public virtual instancetype initWithBundleURLBlock:(RCTBundleURLBlock bundleURLBlock);
 }
 
 interface RCTSafeAreaViewComponentView : public RCTViewComponentView {

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -1693,8 +1693,8 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;
-  public virtual instancetype initWithBundleURL:newArchEnabled:(NSURL* bundleURL, BOOL newArchEnabled);
-  public virtual instancetype initWithBundleURLBlock:newArchEnabled:(RCTBundleURLBlock bundleURLBlock, BOOL newArchEnabled);
+  public virtual instancetype initWithBundleURL:(NSURL* bundleURL);
+  public virtual instancetype initWithBundleURLBlock:(RCTBundleURLBlock bundleURLBlock);
 }
 
 interface RCTSafeAreaViewComponentView : public RCTViewComponentView {

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

@@ -1694,8 +1694,8 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;
-  public virtual instancetype initWithBundleURL:newArchEnabled:(NSURL* bundleURL, BOOL newArchEnabled);
-  public virtual instancetype initWithBundleURLBlock:newArchEnabled:(RCTBundleURLBlock bundleURLBlock, BOOL newArchEnabled);
+  public virtual instancetype initWithBundleURL:(NSURL* bundleURL);
+  public virtual instancetype initWithBundleURLBlock:(RCTBundleURLBlock bundleURLBlock);
 }
 
 interface RCTSafeAreaViewComponentView : public RCTViewComponentView {