Skip to content

Detect auth-redirect failures and report them as auth failures, not missing elements #13

Description

@queso

From the team review of #12 (#12 (comment)):

An expired or wrong auth token (header-based or setup-based) still fails as could not find element on an accounts.shopify.com/select page — the exact misleading failure shape #5 was opened about. Oxygen bypass tokens expire after 2h by default, so this will be hit routinely.

Ask: detect the auth-redirect case (the browser landed on a known auth/login origin different from baseUrl's) and report it as an auth failure naming the configured mechanism (the header name, or the setup block) instead of a missing-element error. This closes the loop on the original complaint in #5.

Related: PR #12 shipped headers + setup + phase-tagged errors, which gives the reporter the context needed to say this precisely.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions