From ff81f1c53f17323109d6ebaf93864baa40a7b31c Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Mon, 10 Aug 2026 16:27:49 +0000 Subject: [PATCH] fix: repair cross-package bugs so all tests and typecheck pass - api.ts: import the real hook export (useDebounce) and re-export as useSearchDebounce, fixing the renamed-hook import mismatch - Button: forward aria-label for accessible name (WCAG 2.2 SC 4.1.2), with dev-time warning + fallback for icon-only buttons - formatDate: strip zero-pad on day so en-AU output is day-first (1/03/2024) - bunfig.toml: preload happy-dom setup so document is defined for root bun test - tsconfig: register bun-types so bun:test resolves --- apps/web/src/lib/api.ts | 12 +++------ bunfig.toml | 3 ++- packages/ui/src/components/Button/Button.tsx | 26 +++++++++++++------- packages/utils/src/format/date.ts | 21 ++++++++-------- tsconfig.json | 1 + 5 files changed, 34 insertions(+), 29 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..b0121b5 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..26b14f2 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,3 @@ [test] -environment = "happy-dom" \ No newline at end of file +environment = "happy-dom" +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..a96882f 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,11 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Icon-only buttons have no visible text, so they must expose an accessible + * name via `aria-label` (WCAG 2.2 AA, SC 4.1.2 Name, Role, Value). + * When `iconOnly` is set and no `aria-label` is supplied we fall back to any + * string `children` and warn in development, so the control is never shipped + * without an accessible name. */ export function Button({ children, @@ -34,13 +32,23 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + const fallbackLabel = typeof children === "string" ? children : "Button" + const accessibleLabel = iconOnly ? (ariaLabel ?? fallbackLabel) : ariaLabel + + if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") { + console.warn( + `[Button] An icon-only Button was rendered without an "aria-label". ` + + `Falling back to "${fallbackLabel}". Provide an explicit aria-label to ` + + `give the button a meaningful accessible name (WCAG 2.2 SC 4.1.2).`, + ) + } + return (