From 5c1d0d0f99e901406bb3949a099152d29867a587 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Tue, 4 Aug 2026 17:00:23 +0000
Subject: [PATCH] fix: repair cross-package imports, DOM test env, date format
 and button a11y

Make all monorepo tests pass and clear tsc errors under the immutable-test
constraint (no test files or dependencies changed):

- api.ts: import useDebounce (utils hook renamed from useThrottle) so both
  the api test and api.ts resolve the same export
- tsconfig: add bun-types so `bun:test` resolves for tsc --noEmit
- formatDate: un-pad the day (en-AU, day-first, 4-digit year) so day 1
  renders "1/03/2024" as the test requires; documented the trade-off
- Button: render aria-label on icon-only buttons (WCAG 2.2 SC 4.1.2) with a
  dev-time warning when omitted
- bunfig.toml/package.json: replace the no-op vitest `environment` key with
  bun's `preload` for the DOM setup (deliberate cleanup; also lets bare
  `bun test` work per-package). No dependency changes.
---
 apps/web/src/lib/api.ts                      | 12 +++------
 bunfig.toml                                  |  2 +-
 package.json                                 |  2 +-
 packages/ui/src/components/Button/Button.tsx | 23 ++++++++++-------
 packages/utils/src/format/date.ts            | 27 ++++++++++++--------
 tsconfig.json                                |  1 +
 6 files changed, 36 insertions(+), 31 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..d9c4314 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..1cb73b3 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
\ No newline at end of file
diff --git a/package.json b/package.json
index 75a6e10..8520f7c 100644
--- a/package.json
+++ b/package.json
@@ -8,7 +8,7 @@
     "apps/*"
   ],
   "scripts": {
-    "test": "bun test packages/utils/test packages/ui/test apps/web/test --preload ./packages/ui/test/setup.ts",
+    "test": "bun test packages/utils/test packages/ui/test apps/web/test",
     "typecheck": "tsc --noEmit"
   },
   "devDependencies": {
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..ba333f0 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,10 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button has no visible text, so it must expose an accessible name
+ * via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value). When
+ * `iconOnly` is set we always render an `aria-label`, falling back to a generic
+ * name and warning in development so the missing label is caught during review.
  */
 export function Button({
   children,
@@ -34,13 +31,21 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons must be given an `aria-label` so screen readers " +
+        "can announce them (WCAG 2.2 SC 4.1.2). Falling back to a generic label.",
+    )
+  }
+
+  const accessibleName = iconOnly ? (ariaLabel ?? "Button") : ariaLabel
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleName}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..2bad69f 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,26 @@
 /**
  * Date formatting utilities.
+ */
+
+/**
+ * Format a date as day-first D/MM/YYYY for Australian usage, e.g. `1/03/2024`.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `en-AU` resolves an all-numeric day/month/year skeleton to a zero-padded
+ * `dd/MM/y` pattern, so the day would otherwise render as `01`. Option order
+ * has no effect on this — the locale owns field ordering and padding. We format
+ * to parts and strip the day's leading zero, which keeps the `en-AU` locale and
+ * a four-digit year (unlike `dateStyle: "short"`, which yields `1/3/24`).
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+
+  return parts
+    .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]