diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..d9c4314 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app-facing name +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..1cb73b3 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/package.json b/package.json index 75a6e10..8520f7c 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "apps/*" ], "scripts": { - "test": "bun test packages/utils/test packages/ui/test apps/web/test --preload ./packages/ui/test/setup.ts", + "test": "bun test packages/utils/test packages/ui/test apps/web/test", "typecheck": "tsc --noEmit" }, "devDependencies": { diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..ba333f0 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,10 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * An icon-only button has no visible text, so it must expose an accessible name + * via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value). When + * `iconOnly` is set we always render an `aria-label`, falling back to a generic + * name and warning in development so the missing label is caught during review. */ export function Button({ children, @@ -34,13 +31,21 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) { + console.warn( + "Button: `iconOnly` buttons must be given an `aria-label` so screen readers " + + "can announce them (WCAG 2.2 SC 4.1.2). Falling back to a generic label.", + ) + } + + const accessibleName = iconOnly ? (ariaLabel ?? "Button") : ariaLabel + return (