Ignore un-escaped commas when parsing single-value properties#128
Open
pinchartl wants to merge 1 commit into
Open
Ignore un-escaped commas when parsing single-value properties#128pinchartl wants to merge 1 commit into
pinchartl wants to merge 1 commit into
Conversation
Some non-conformant implementations of RFC 5545 (namely PRODID:-//Microsoft Corporation//Outlook MIMEDIR//EN) fail to escape COMMA characters in text property values. For instance, DESCRIPTION:Hi Laurent,\nYou have been requested to meet with [...] The COMMA character is used to delimitate values in multi-value properties, and must be escaped according to the RFC when a literal comma is needed. When parsing the above DESCRIPTION property, vobject returns "Hi Laurent" as the property value. Ignoring un-escaped comas in properties defined as accepting a single value should be safe. Fortunately, vobject marks those properties by associating them with TextBehaviour. We can simply change the behaviour to not use the comma as a list separator. Closes: py-vobject#55 Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some non-conformant implementations of RFC 5545 (namely PRODID:-//Microsoft Corporation//Outlook MIMEDIR//EN) fail to escape COMMA characters in text property values. For instance,
DESCRIPTION:Hi Laurent,\nYou have been requested to meet with [...]
The COMMA character is used to delimitate values in multi-value properties, and must be escaped according to the RFC when a literal comma is needed. When parsing the above DESCRIPTION property, vobject returns "Hi Laurent" as the property value.
Ignoring un-escaped comas in properties defined as accepting a single value should be safe. Fortunately, vobject marks those properties by associating them with TextBehaviour. We can simply change the behaviour to not use the comma as a list separator.
Closes: #55