From a35096fc9d92a712768dc334702293c3e7da0115 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 6 Oct 2026 23:00:43 -0600 Subject: [PATCH 1/4] elevation/apparent elevation order switch --- pvlib/spa.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/spa.py b/pvlib/spa.py index fe072b2cc9..a860584122 100644 --- a/pvlib/spa.py +++ b/pvlib/spa.py @@ -1074,8 +1074,8 @@ def solar_position(unixtime, lat, lon, elev, pressure, temp, delta_t, Numpy Array with elements: apparent zenith, zenith, - elevation, apparent_elevation, + elevation, azimuth, equation_of_time From 999835a5d82e146e4951f042b8fafb9ba2966c3d Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 6 Oct 2026 23:06:27 -0600 Subject: [PATCH 2/4] Update v0.16.2.rst --- docs/sphinx/source/whatsnew/v0.16.2.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 537f8db20e..6c7e417f9f 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -14,6 +14,9 @@ Deprecations Bug fixes ~~~~~~~~~ +* Fix the documented return order in :py:func:`pvlib.spa.solar_position`, + which listed ``elevation`` and ``apparent_elevation`` in the wrong order. + (:issue:`2886`, :pull:`2887`) Enhancements From 02e56e19974383e72830b88d328e2dccad29cf38 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 6 Oct 2026 23:08:31 -0600 Subject: [PATCH 3/4] Update v0.16.2.rst --- docs/sphinx/source/whatsnew/v0.16.2.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 6c7e417f9f..9c8d058a6d 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -14,9 +14,6 @@ Deprecations Bug fixes ~~~~~~~~~ -* Fix the documented return order in :py:func:`pvlib.spa.solar_position`, - which listed ``elevation`` and ``apparent_elevation`` in the wrong order. - (:issue:`2886`, :pull:`2887`) Enhancements @@ -28,6 +25,9 @@ Documentation * Clarified in :py:func:`pvlib.tracking.singleaxis` that the tracker rotation minimizes the angle of incidence (AOI) to maximize the use of direct normal irradiance (DNI). (:issue:`2314`, :pull:`2869`) +* Fix the documented return order in :py:func:`pvlib.spa.solar_position`, + which listed ``elevation`` and ``apparent_elevation`` in the wrong order. + (:issue:`2886`, :pull:`2887`) Testing From ed53cfe91018bb39532bb773177722087900456f Mon Sep 17 00:00:00 2001 From: Rajiv Daxini <143435106+RDaxini@users.noreply.github.com> Date: Wed, 7 Oct 2026 12:52:42 -0600 Subject: [PATCH 4/4] Update docs/sphinx/source/whatsnew/v0.16.2.rst Co-authored-by: Cliff Hansen --- docs/sphinx/source/whatsnew/v0.16.2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 9c8d058a6d..9c0c22a172 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -25,8 +25,8 @@ Documentation * Clarified in :py:func:`pvlib.tracking.singleaxis` that the tracker rotation minimizes the angle of incidence (AOI) to maximize the use of direct normal irradiance (DNI). (:issue:`2314`, :pull:`2869`) -* Fix the documented return order in :py:func:`pvlib.spa.solar_position`, - which listed ``elevation`` and ``apparent_elevation`` in the wrong order. +* Fix the :py:func:`pvlib.spa.solar_position` docstring, which listed + outputs ``elevation`` and ``apparent_elevation`` in the wrong order. (:issue:`2886`, :pull:`2887`)