Skip to content

Fix issue #117 Specify base go.mod for app creation#119

Open
yxuco wants to merge 4 commits into
project-flogo:masterfrom
yxuco:master
Open

Fix issue #117 Specify base go.mod for app creation#119
yxuco wants to merge 4 commits into
project-flogo:masterfrom
yxuco:master

Conversation

@yxuco

@yxuco yxuco commented Dec 11, 2020

Copy link
Copy Markdown

@lixingwang

Copy link
Copy Markdown
Contributor

@yxuco This feature only for specifying the version of flow and core right? We do have an option --cv to specify the core version. what exactly the issue or use case you want to achieve here? by exposing go.mod file which too technical for the user I think

@yxuco

yxuco commented Jan 4, 2021

Copy link
Copy Markdown
Author

--cv is not flexible enough to override other things. For example, I need to build package with shim trigger that requires patches for both flogo/core and flogo/flow versions, as well as changing the module name of the resulting package. It would be simpler to allow a startup mod file that overrides all these attributes, instead of providing multiple flags to override individual attributes such as --cv.

@lixingwang

Copy link
Copy Markdown
Contributor

@mellistibco thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants