fix lint warnings

Author: catilac

crates/processing_ffi/src/lib.rs

@@ -3005,63 +3005,57 @@ pub extern "C" fn processing_filter_set_passes(filter_id: u64, passes: u32) {
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_blur() -> u64 {
     error::clear_error();
-    error::check(|| filter_blur())
-        .map(|e| e.to_bits())
-        .unwrap_or(0)
+    error::check(filter_blur).map(|e| e.to_bits()).unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_invert() -> u64 {
     error::clear_error();
-    error::check(|| filter_invert())
+    error::check(filter_invert)
         .map(|e| e.to_bits())
         .unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_gray() -> u64 {
     error::clear_error();
-    error::check(|| filter_gray())
-        .map(|e| e.to_bits())
-        .unwrap_or(0)
+    error::check(filter_gray).map(|e| e.to_bits()).unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_threshold() -> u64 {
     error::clear_error();
-    error::check(|| filter_threshold())
+    error::check(filter_threshold)
         .map(|e| e.to_bits())
         .unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_posterize() -> u64 {
     error::clear_error();
-    error::check(|| filter_posterize())
+    error::check(filter_posterize)
         .map(|e| e.to_bits())
         .unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_opaque() -> u64 {
     error::clear_error();
-    error::check(|| filter_opaque())
+    error::check(filter_opaque)
         .map(|e| e.to_bits())
         .unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_erode() -> u64 {
     error::clear_error();
-    error::check(|| filter_erode())
-        .map(|e| e.to_bits())
-        .unwrap_or(0)
+    error::check(filter_erode).map(|e| e.to_bits()).unwrap_or(0)
 }
 
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_filter_dilate() -> u64 {
     error::clear_error();
-    error::check(|| filter_dilate())
+    error::check(filter_dilate)
         .map(|e| e.to_bits())
         .unwrap_or(0)
 }

crates/processing_render/src/graphics.rs

@@ -463,10 +463,10 @@ pub fn set_bloom(
 
     commands.entity(entity).insert((bloom, Hdr));
 
-    if let Ok(mut tm) = tonemapping_query.get_mut(entity) {
-        if *tm == Tonemapping::None {
-            *tm = Tonemapping::TonyMcMapface;
-        }
+    if let Ok(mut tm) = tonemapping_query.get_mut(entity)
+        && *tm == Tonemapping::None
+    {
+        *tm = Tonemapping::TonyMcMapface;
     }
 
     Ok(())

crates/processing_render/src/particles/point_render.rs

@@ -141,10 +141,10 @@ impl Specializer<RenderPipeline> for RasterSpecializer {
             target.format = key.format;
             target.blend = key.blend;
         }
-        if key.blend.is_some() {
-            if let Some(depth) = descriptor.depth_stencil.as_mut() {
-                depth.depth_write_enabled = Some(false);
-            }
+        if key.blend.is_some()
+            && let Some(depth) = descriptor.depth_stencil.as_mut()
+        {
+            depth.depth_write_enabled = Some(false);
         }
         Ok(key)
     }

crates/processing_render/src/particles/scatter.rs

@@ -101,7 +101,7 @@ fn extract_scatter_geometry(mesh: &mut Mesh) -> Result<(Vec<[f32; 3]>, Vec<u32>)
         }
     };
 
-    if dense_indices.len() % 3 != 0 {
+    if !dense_indices.len().is_multiple_of(3) {
         return Err(ProcessingError::InvalidArgument(
             "scatter source mesh has a non-triangle index list".to_string(),
         ));

crates/processing_render/src/render/primitive/shape.rs

@@ -245,7 +245,7 @@ pub fn build_direct_fill(mesh: &mut Mesh, builder: &ShapeBuilder, color: Color)
 
     match builder.kind {
         ShapeKind::Triangles => {
-            for chunk in vertices.chunks_exact(3) {
+            for chunk in vertices.as_chunks::<3>().0 {
                 push_triangle(
                     mesh, color, chunk[0].0, chunk[0].1, chunk[1].0, chunk[1].1, chunk[2].0,
                     chunk[2].1,
@@ -296,7 +296,7 @@ pub fn build_direct_fill(mesh: &mut Mesh, builder: &ShapeBuilder, color: Color)
             }
         }
         ShapeKind::Quads => {
-            for chunk in vertices.chunks_exact(4) {
+            for chunk in vertices.as_chunks::<4>().0 {
                 push_quad(
                     mesh, color, chunk[0].0, chunk[0].1, chunk[1].0, chunk[1].1, chunk[2].0,
                     chunk[2].1, chunk[3].0, chunk[3].1,
@@ -344,7 +344,7 @@ pub fn build_direct_stroke(
 
     match builder.kind {
         ShapeKind::Lines => {
-            for chunk in vertices.chunks_exact(2) {
+            for chunk in vertices.as_chunks::<2>().0 {
                 let mut pb = Path::builder();
                 pb.begin(Point::new(chunk[0].0, chunk[0].1));
                 pb.line_to(Point::new(chunk[1].0, chunk[1].1));
@@ -359,7 +359,7 @@ pub fn build_direct_stroke(
             }
         }
         ShapeKind::Triangles => {
-            for chunk in vertices.chunks_exact(3) {
+            for chunk in vertices.as_chunks::<3>().0 {
                 stroke_polygon(
                     mesh,
                     &[chunk[0], chunk[1], chunk[2]],
@@ -407,7 +407,7 @@ pub fn build_direct_stroke(
             }
         }
         ShapeKind::Quads => {
-            for chunk in vertices.chunks_exact(4) {
+            for chunk in vertices.as_chunks::<4>().0 {
                 stroke_polygon(
                     mesh,
                     &[chunk[0], chunk[1], chunk[2], chunk[3]],