From 5a6a32bf16b7b68528331dfaed80d5f282bc11f5 Mon Sep 17 00:00:00 2001 From: MyuTsu Date: Fri, 29 May 2026 11:18:12 +0200 Subject: [PATCH 1/3] fix(target): PluginFormcreatorQuestion excluded from itemtypes when saving associated elements --- inc/targetticket.class.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/inc/targetticket.class.php b/inc/targetticket.class.php index 1c9269b6c..c3f433ca1 100644 --- a/inc/targetticket.class.php +++ b/inc/targetticket.class.php @@ -1180,7 +1180,7 @@ protected function showAssociateSettings($rand) { $rows = $itemTargetTicket->find([ self::getForeignKeyField() => $this->getID(), [ - 'NOT' => ['itemtype' => [PluginFormcreatorTargetTicket::class, Ticket::class]], + 'NOT' => ['itemtype' => [PluginFormcreatorTargetTicket::class, PluginFormcreatorQuestion::class, Ticket::class]], ], ]); foreach ($rows as $row) { @@ -1251,7 +1251,7 @@ protected function setTargetAssociatedItem(array $data, PluginFormcreatorFormAns $rows = $itemTargetTicket->find([ self::getForeignKeyField() => $this->getID(), [ - 'NOT' => ['itemtype' => [PluginFormcreatorTargetTicket::class, Ticket::class]], + 'NOT' => ['itemtype' => [PluginFormcreatorTargetTicket::class, PluginFormcreatorQuestion::class, Ticket::class]], ], ]); $data['items_id'] = []; @@ -1551,6 +1551,7 @@ private function saveAssociatedItems($input) { $itemTargetTicket->deleteByCriteria([ 'NOT' => ['itemtype' => [ PluginFormcreatorTargetTicket::class, + PluginFormcreatorQuestion::class, Ticket::class, ]], self::getForeignKeyField() => $this->getID(), From 757a25373736e035ab7e49a92114d279b429218a Mon Sep 17 00:00:00 2001 From: MyuTsu Date: Wed, 3 Jun 2026 11:38:40 +0200 Subject: [PATCH 2/3] fix ci --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2ab8944c1..dd25984e3 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -5,7 +5,7 @@ on: env: GLPI_SOURCE: "https://github.com/glpi-project/glpi" - GLPI_PACKAGE_URL_BASE: "https://nightly.glpi-project.org/glpi" + GLPI_PACKAGE_URL_BASE: "https://github.com/glpi-project/glpi-project.github.io/raw/refs/heads/main/glpi" CS: 7.4 DB_HOST: 127.0.0.1 MYSQL_ROOT_USER: root From 5a7da70ccd5a07528e3560534bacbfbef8582800 Mon Sep 17 00:00:00 2001 From: MyuTsu Date: Wed, 3 Jun 2026 17:25:40 +0200 Subject: [PATCH 3/3] revert ci --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index dd25984e3..2ab8944c1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -5,7 +5,7 @@ on: env: GLPI_SOURCE: "https://github.com/glpi-project/glpi" - GLPI_PACKAGE_URL_BASE: "https://github.com/glpi-project/glpi-project.github.io/raw/refs/heads/main/glpi" + GLPI_PACKAGE_URL_BASE: "https://nightly.glpi-project.org/glpi" CS: 7.4 DB_HOST: 127.0.0.1 MYSQL_ROOT_USER: root