Skip to content

Commit 3a710fa

Browse files
authored
ext/zip: declare true as the return type of zip_entry_close() (#23395)
The function has two exits: RETURN_THROWS for a bad parameter or a stale resource, and an unconditional RETURN_TRUE after closing the entry. Nothing returns false.
1 parent ee908f5 commit 3a710fa

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

ext/zip/php_zip.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function zip_entry_open($zip_dp, $zip_entry, string $mode = "rb"): bool {}
3232
* @param resource $zip_entry
3333
*/
3434
#[\Deprecated(since: '8.0')]
35-
function zip_entry_close($zip_entry): bool {}
35+
function zip_entry_close($zip_entry): true {}
3636

3737
/**
3838
* @param resource $zip_entry

ext/zip/php_zip_arginfo.h

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)