feat: new api for compaction#429
Open
dkharms wants to merge 3 commits into
Open
Conversation
dkharms
force-pushed
the
0-fm-compaction-api
branch
from
1f7bfdb to
96ba81f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've implemented all necessary API for compaction. And also changed visibility of all methods inside
fracmanagerpackage since they should not be exported.I expect that there will be slight tweaks and changes to this API (e.g. method signature change) but the whole idea will be the same.
If you have used LLM/AI assistance please provide model name and full prompt: