[ENHANCEMENT] Consider moving from Newtonsoft to System.Text.Json

[nuttytree]

Description

In general it seems most major libraries are moving way from Newtonsoft to System.Text.Json. It would be good to see this library do the same.

Benefits

System.Text.Json seems to be the future of JSON parsing in .NET and is faster than Newtonsoft.

Detail

No response

Examples

No response

Risks/Downsides

No response

[nuttytree]

I did a little digging into this. For .NET 3.5/4.0 and .NET Standard 1.6 using System.Text.Json is not an option. However with a bit of conditional code it would be pretty easy and straightforward to switch .NET Standard 2.0 to System.Text.Json. Would you be open to me putting up a PR to make the change?

[mikechu-optimizely]

Holy smokes. This Issue didn't ping my radar. @nuttytree I'm genuinely sorry about that.

Did you find your solution yet? We're always open to a PR which helps us understand your problem and solution space effectively.

Note: We have on our roadmap to review and potentially deprecate end of life versions and move towards Core.

[nuttytree]

Not a big deal, we are trying to move away from Newtonsoft in general and this NuGet is one of the big sources of it getting pulled in for us. I will try and get a PR up in the next month or so, I just didn't want to do the work if it wouldn't get accepted.

[mikechu-optimizely]

Totally understand. Modernization is on our horizon too.

I've created internal work item FSSDK-11026 to track this Issue/PR.

Thanks much for the collab.

[Scrambles56]

Hi there!

I know this is an older issue now, but Newtonsoft.Json is a piece that is prevent our applications from moving towards AOT builds. In the future, it'd be nice if there could be a STJ implementation that used Source Generated serializers. It'd mean that the SDK would be safe for AOT.

Our use case is in a low usage API service, that we're trying to convert to AOT for startup speed. If Optimizely was using this solution, we wouldn't be blocked here and able to move the service towards a serverless setup.