Skip to content

Commit 33dadce

Browse files
committed
typing: Typing updates for openstacksdk 4.16.0
Change-Id: Id4e5c06161709ee862eaab0c3004bec9478f838e Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
1 parent 733b432 commit 33dadce

3 files changed

Lines changed: 6 additions & 12 deletions

File tree

openstackclient/compute/v2/service.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -265,17 +265,15 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
265265
enabled = False
266266

267267
if enabled is not None:
268-
# these are bugs in SDK
269-
# https://review.opendev.org/c/openstack/openstacksdk/+/992549
270268
if enabled:
271269
compute_client.enable_service(
272-
service_id, # type: ignore[arg-type]
270+
service_id,
273271
parsed_args.host,
274272
parsed_args.service,
275273
)
276274
else:
277275
compute_client.disable_service(
278-
service_id, # type: ignore[arg-type]
276+
service_id,
279277
parsed_args.host,
280278
parsed_args.service,
281279
parsed_args.disable_reason,
@@ -295,10 +293,8 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
295293
msg = _('--os-compute-api-version 2.11 or later is required')
296294
raise exceptions.CommandError(msg)
297295
try:
298-
# FIXME(stephenfin): This is broken between 2.11 and 2.53. What
299-
# is the expected ID here?
300296
compute_client.update_service_forced_down(
301-
service_id, # type: ignore[arg-type]
297+
service_id,
302298
parsed_args.host,
303299
parsed_args.service,
304300
force_down,

openstackclient/volume/v2/volume_backup.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -404,12 +404,10 @@ def take_action(
404404
)
405405
raise exceptions.CommandError(msg % parsed_args.volume)
406406

407-
# this is a bug in SDK
408-
# https://review.opendev.org/c/openstack/openstacksdk/+/992473
409407
restore = volume_client.restore_backup(
410408
backup.id,
411-
volume=volume_id, # type: ignore[arg-type]
412-
name=volume_name, # type: ignore[arg-type]
409+
volume=volume_id,
410+
name=volume_name,
413411
)
414412

415413
data = utils.get_dict_properties(restore, columns)

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
cryptography>=2.7 # BSD/Apache-2.0
66
cliff>=4.13.0 # Apache-2.0
77
iso8601>=0.1.11 # MIT
8-
openstacksdk>=4.14.0 # Apache-2.0
8+
openstacksdk>=4.16.0 # Apache-2.0
99
osc-lib>=4.6.0 # Apache-2.0
1010
oslo.i18n>=3.15.3 # Apache-2.0
1111
python-keystoneclient>=3.22.0 # Apache-2.0

0 commit comments

Comments
 (0)