Fix tool output accessibility labels#650
Conversation
Add accessible names to the TaskList tool burst header and expanded body so screen readers can announce both the summary and step output without changing the header-only click target. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed June 2, 2026, 7:43 PM ET / 23:43 UTC. Summary Reproducibility: no. high-confidence runtime reproduction was established in this read-only review. Source inspection does show the current TaskList body is a sibling outside the header Button and lacks an explicit automation name, matching the linked accessibility report. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land a narrow automation-metadata fix that preserves the header-only click target and, if maintainers want extra assurance, verify the expanded TaskList card with Windows Narrator or Inspect. Do we have a high-confidence way to reproduce the issue? No high-confidence runtime reproduction was established in this read-only review. Source inspection does show the current TaskList body is a sibling outside the header Button and lacks an explicit automation name, matching the linked accessibility report. Is this the best way to solve the issue? Yes, the PR is a narrow maintainable solution: it adds explicit automation metadata through the existing FunctionalUI AutomationName path without restructuring the click target or body selection behavior. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against bfeb3b5c90be. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Closes #590.
Review notes
Validation
./build.ps1from the direct long worktree path still hits a Windows App SDK PRI path-length/generated-file failure in WinUI (CommunityToolkit.WinUI.Controls.SettingsControls.pri.xml). The same worktree passed./build.ps1withOPENCLAW_REPO_ROOTset to the real worktree and cwd shortened through a temporaryC:\oc590junction.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restorepassed: 2074 total, 0 failed, 2045 succeeded, 29 skipped.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restorepassed: 935 total, 0 failed.