From b250ed39e5a14d4458851bec9e1f84d9940174c5 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 27 Jul 2026 16:04:31 -0700 Subject: [PATCH 1/3] fix(ui): add default aria-label to toggle Signed-off-by: Aviv Keller --- packages/ui-components/src/Common/ThemeToggle/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/Common/ThemeToggle/index.tsx b/packages/ui-components/src/Common/ThemeToggle/index.tsx index 923aba5f90d16..8c874a4c1c4eb 100644 --- a/packages/ui-components/src/Common/ThemeToggle/index.tsx +++ b/packages/ui-components/src/Common/ThemeToggle/index.tsx @@ -30,7 +30,7 @@ const themes: Array = ['system', 'light', 'dark']; const ThemeToggle: FC = ({ onChange = () => {}, currentTheme = 'system', - ariaLabel, + ariaLabel = 'Toggle light/dark theme', themeLabels = { system: 'System', light: 'Light', dark: 'Dark' }, }) => { const TriggerIcon = themeIcons[currentTheme]; From b7458494579757530cf419fda1204bcf2117b9e7 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 27 Jul 2026 16:05:44 -0700 Subject: [PATCH 2/3] Add default aria-label to ThemeToggle Add a default aria-label to the ThemeToggle component. Signed-off-by: Aviv Keller --- .changeset/theme-toggle-aria.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/theme-toggle-aria.md diff --git a/.changeset/theme-toggle-aria.md b/.changeset/theme-toggle-aria.md new file mode 100644 index 0000000000000..c2394381f5aca --- /dev/null +++ b/.changeset/theme-toggle-aria.md @@ -0,0 +1,5 @@ +--- +'@node-core/ui-components': patch +--- + +Add a default `aria-label` to `ThemeToggle`. From 2ae8129ae2280bc9b421ed51f993d0928bb8cf38 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 27 Jul 2026 16:06:13 -0700 Subject: [PATCH 3/3] fixup! Signed-off-by: Aviv Keller --- packages/ui-components/src/Common/ThemeToggle/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/Common/ThemeToggle/index.tsx b/packages/ui-components/src/Common/ThemeToggle/index.tsx index 8c874a4c1c4eb..401f1472e4bad 100644 --- a/packages/ui-components/src/Common/ThemeToggle/index.tsx +++ b/packages/ui-components/src/Common/ThemeToggle/index.tsx @@ -30,7 +30,7 @@ const themes: Array = ['system', 'light', 'dark']; const ThemeToggle: FC = ({ onChange = () => {}, currentTheme = 'system', - ariaLabel = 'Toggle light/dark theme', + ariaLabel = 'Select theme', themeLabels = { system: 'System', light: 'Light', dark: 'Dark' }, }) => { const TriggerIcon = themeIcons[currentTheme];