From 50b88184a0fa1bfd84c36e58375411bce753d285 Mon Sep 17 00:00:00 2001 From: Renegade334 Date: Mon, 20 Apr 2026 21:13:05 +0200 Subject: [PATCH] quic: disable building ngtcp2 examples The ngtcp2 client and server examples are built with the intention of using them as reference implementations for future quic tests. However, as of ngtcp2 1.22.0, these examples require c++-23 libraries, which doesn't match the current Node.js build requirements. Signed-off-by: Renegade334 --- node.gypi | 7 ++++--- test/parallel/parallel.status | 4 ++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/node.gypi b/node.gypi index 3636633c622abd..e66a10ac077a78 100644 --- a/node.gypi +++ b/node.gypi @@ -469,9 +469,10 @@ './deps/ngtcp2/ngtcp2.gyp:ngtcp2', './deps/ngtcp2/ngtcp2.gyp:nghttp3', - # For tests - './deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_server', - './deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_client', + # Example implementations used in test suite + # TODO(@nodejs/quic): re-enable once builds support c++-23 headers + #'./deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_server', + #'./deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_client', ], }], ], diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 5c7fe47927611f..ce015d029077bd 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -22,6 +22,10 @@ test-snapshot-incompatible: SKIP # https://github.com/nodejs/node/issues/53579 test-snapshot-reproducible: SKIP +# ngtcp2's example implementations cannot be built without c++-23 headers. +test-quic-test-client: SKIP +test-quic-test-server: SKIP + [$system==win32] # https://github.com/nodejs/node/issues/59090 test-inspector-network-fetch: PASS, FLAKY