Version
v24.14.1
The typo is also present in the v26.8.1 source and
in the current main branch.
Platform
Microsoft Windows NT 10.0.26200.0 x64
Subsystem
worker_threads
What steps will reproduce the bug?
Run the following without any third-party dependencies:
const { Worker } = require('node:worker_threads');
const worker = new Worker('', { eval: true });
const listener = () => {};
worker.on('message', listener);
worker.on('messageerror', listener);
worker.on('exit', () => {
console.log({
message: worker.listenerCount('message'),
messageerror: worker.listenerCount('messageerror'),
});
});
How often does it reproduce? Is there a required condition?
It reproduces every time on v24.14.1 and on the current main branch at
7177c14789a7376866dfe6c04f5cd4da489cfbe6. It occurs both when a worker exits
normally and when it is stopped with worker.terminate().
What is the expected behavior? Why is that the expected behavior?
Both messaging listener counts should be zero while the exit listener is
running:
{ message: 0, messageerror: 0 }
The worker exit cleanup explicitly removes the message listeners before
emitting exit and appears intended to do the same for messageerror.
What do you see instead?
The message listener is removed, but the messageerror listener is still
present:
{ message: 0, messageerror: 1 }
Additional information
The targeted cleanup currently calls
removeAllListeners('messageerrors'), but the event name is messageerror:
|
this.removeAllListeners('message'); |
|
this.removeAllListeners('messageerrors'); |
The typo was introduced in commit 5968c5423530aeaa10c02eae3e8423c6514cdd1a:
5968c54
There is a later generic removeAllListeners() call after the exit event is
emitted, so this report does not claim a persistent listener leak. The observed
problem is that the targeted pre-exit cleanup does not remove messageerror
listeners as intended.
Version
v24.14.1
The typo is also present in the v26.8.1 source and
in the current
mainbranch.Platform
Subsystem
worker_threads
What steps will reproduce the bug?
Run the following without any third-party dependencies:
How often does it reproduce? Is there a required condition?
It reproduces every time on v24.14.1 and on the current
mainbranch at7177c14789a7376866dfe6c04f5cd4da489cfbe6. It occurs both when a worker exitsnormally and when it is stopped with
worker.terminate().What is the expected behavior? Why is that the expected behavior?
Both messaging listener counts should be zero while the
exitlistener isrunning:
The worker exit cleanup explicitly removes the
messagelisteners beforeemitting
exitand appears intended to do the same formessageerror.What do you see instead?
The
messagelistener is removed, but themessageerrorlistener is stillpresent:
Additional information
The targeted cleanup currently calls
removeAllListeners('messageerrors'), but the event name ismessageerror:node/lib/internal/worker.js
Lines 395 to 396 in 7177c14
The typo was introduced in commit
5968c5423530aeaa10c02eae3e8423c6514cdd1a:5968c54
There is a later generic
removeAllListeners()call after theexitevent isemitted, so this report does not claim a persistent listener leak. The observed
problem is that the targeted pre-
exitcleanup does not removemessageerrorlisteners as intended.