From e962adaccce6dc90bdaadae997378a97803642fb Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Wed, 29 Jul 2026 17:03:02 +0000 Subject: [PATCH 1/2] Bump @vscode/test-electron to 3.1.0 so tests launch VS Code >=1.110 on macOS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit VS Code 1.110 renamed the macOS main binary from Contents/MacOS/Electron to the product name and later removed the compatibility symlink (microsoft/vscode#326502, 2026-07-20), so @vscode/test-electron <=3.0.0 — which hardcodes the Electron name — fails to launch downloaded stable builds on macOS with 'spawn .../Contents/MacOS/Electron ENOENT'. 3.1.0 resolves the executable from the bundle's Info.plist CFBundleExecutable (microsoft/vscode-test#348, #349), letting the tests track latest stable VS Code again without pinning. --- Extension/package.json | 2 +- Extension/yarn.lock | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Extension/package.json b/Extension/package.json index 1321404ff..fba109be9 100644 --- a/Extension/package.json +++ b/Extension/package.json @@ -7203,7 +7203,7 @@ "@vscode/debugadapter": "^1.65.0", "@vscode/debugprotocol": "^1.65.0", "@vscode/dts": "^0.4.0", - "@vscode/test-electron": "^2.3.10", + "@vscode/test-electron": "^3.1.0", "@vscode/vsce": "^3.9.2", "async-child-process": "^1.1.1", "await-notify": "^1.0.1", diff --git a/Extension/yarn.lock b/Extension/yarn.lock index ed4fa4354..9fa5674fe 100644 --- a/Extension/yarn.lock +++ b/Extension/yarn.lock @@ -1055,10 +1055,10 @@ "@microsoft/1ds-post-js" "^4.3.4" "@microsoft/applicationinsights-web-basic" "^3.3.4" -"@vscode/test-electron@^2.3.10": - version "2.5.2" - resolved "https://pkgs.dev.azure.com/azure-public/VisualCpp/_packaging/cpp_PublicPackages/npm/registry/@vscode/test-electron/-/test-electron-2.5.2.tgz#f7d4078e8230ce9c94322f2a29cc16c17954085d" - integrity sha1-99QHjoIwzpyUMi8qKcwWwXlUCF0= +"@vscode/test-electron@^3.1.0": + version "3.1.0" + resolved "https://pkgs.dev.azure.com/azure-public/VisualCpp/_packaging/cpp_PublicPackages/npm/registry/@vscode/test-electron/-/test-electron-3.1.0.tgz#46b93d118dcd3b3c89caae296a13f9a7f5eb63c5" + integrity sha1-Rrk9EY3NOzyJyq4pahP5p/XrY8U= dependencies: http-proxy-agent "^7.0.2" https-proxy-agent "^7.0.5" @@ -1744,13 +1744,6 @@ brace-expansion@^1.1.7: balanced-match "^1.0.0" concat-map "0.0.1" -brace-expansion@^5.0.2: - version "5.0.8" - resolved "https://pkgs.dev.azure.com/azure-public/VisualCpp/_packaging/cpp_PublicPackages/npm/registry/brace-expansion/-/brace-expansion-5.0.8.tgz#135ad0d8d808eb18eb5e0ec9a21f3a0b92ef18cf" - integrity sha1-E1rQ2NgI6xjrXg7Joh86C5LvGM8= - dependencies: - balanced-match "^4.0.2" - brace-expansion@^2.0.1: version "2.1.2" resolved "https://pkgs.dev.azure.com/azure-public/VisualCpp/_packaging/cpp_PublicPackages/npm/registry/brace-expansion/-/brace-expansion-2.1.2.tgz#0bba2271feb7d458b0d31ad13625aaa4754431e2" @@ -1758,6 +1751,13 @@ brace-expansion@^2.0.1: dependencies: balanced-match "^1.0.0" +brace-expansion@^5.0.2: + version "5.0.8" + resolved "https://pkgs.dev.azure.com/azure-public/VisualCpp/_packaging/cpp_PublicPackages/npm/registry/brace-expansion/-/brace-expansion-5.0.8.tgz#135ad0d8d808eb18eb5e0ec9a21f3a0b92ef18cf" + integrity sha1-E1rQ2NgI6xjrXg7Joh86C5LvGM8= + dependencies: + balanced-match "^4.0.2" + braces@^3.0.3, braces@~3.0.2: version "3.0.3" resolved "https://pkgs.dev.azure.com/azure-public/VisualCpp/_packaging/cpp_PublicPackages/npm/registry/braces/-/braces-3.0.3.tgz#490332f40919452272d55a8480adc0c441358789" From 0bbd36695fb7f880310ec50926efec8637a3a880 Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Wed, 29 Jul 2026 17:14:36 +0000 Subject: [PATCH 2/2] Move test VS Code pin to 1.131.0 With @vscode/test-electron 3.1.0 the macOS 1.131.0 bundle launches correctly, so advance the pinned test VS Code from 1.130.0 to the current stable 1.131.0. --- Extension/.scripts/vscode.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Extension/.scripts/vscode.ts b/Extension/.scripts/vscode.ts index f77638ef2..de22ac20b 100644 --- a/Extension/.scripts/vscode.ts +++ b/Extension/.scripts/vscode.ts @@ -15,9 +15,9 @@ export const extensionsDir = resolve(isolated, 'extensions'); export const userDir = resolve(isolated, 'user-data'); export const settings = resolve(userDir, "User", 'settings.json'); -// Pin the test VS Code build; the newest stable can ship a bundle layout that the installed -// @vscode/test-electron fails to launch (macOS arm64 1.131.0 spawns Electron with ENOENT). -export const testVSCodeVersion = '1.130.0'; +// Pin the test VS Code build to a known-good stable release for deterministic CI instead of +// always pulling latest. Launching macOS 1.110+ builds requires @vscode/test-electron >= 3.1.0. +export const testVSCodeVersion = '1.131.0'; export const options = { version: testVSCodeVersion,