From ea4680ef97428b35c5ad4a86477e4a32df6a6862 Mon Sep 17 00:00:00 2001 From: Damyan Pepper Date: Fri, 16 Oct 2026 10:16:47 -0700 Subject: [PATCH] Add missing-tests meme guidance for Copilot reviews Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a003681e-c910-420c-a7e6-7b79d07bd97e --- .github/copilot-instructions.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index ff7a758d2d..7113c8473a 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -31,3 +31,22 @@ Comment tone: - Use a stronger ask when the PR clearly appears to be a user-visible bug fix or feature. - If release-note coverage may come in a related PR (including a future PR), ask the author to point to that planned coverage. - If uncertain, prefer the gentle **"Did you consider adding a release note?"** wording. + +## Missing tests + +When reviewing a pull request, check whether it includes any test changes. + +If a PR changes functional behavior (for example, compiler, validator, or runtime source code) and does not add or modify **any** tests, include this meme in the review summary: + +```markdown +![Seagulls asking "TEST CASE?"](https://github.com/user-attachments/assets/dbb4ac69-6c21-40d7-9b35-d3fc1d2d33d4) +``` + +Follow the meme with a brief request to add tests that cover the change. + +Only post the meme when tests are entirely absent. Do not post it when: +- The PR adds or modifies tests, even if coverage seems incomplete. Leave a normal review comment about the specific gaps instead. +- The PR is docs-only, infrastructure-only, a dependency bump, or a refactor marked NFC (no functional change). +- The PR explains why tests are infeasible or points to tests in a related PR. + +Post the meme at most once per PR.