Skip to content

Use D3D12_SDK_VERSION macro consistently across samples, instead of explicitly setting the version in source files. #953

@charles-lunarg

Description

@charles-lunarg

Many samples explicitly reference the d3d12 sdk version

extern "C" { __declspec(dllexport) extern const UINT D3D12SDKVersion = 618; }

Whenever the SDK version is updated, the source files must also be updated, which is a tedius and annoying process. If, instead, the version is set to D3D12_SDK_VERSION then samples will automatically use the correct version.

extern "C" { __declspec(dllexport) extern const UINT D3D12SDKVersion = D3D12_SDK_VERSION; }

Example locations of this: (But there are many many more!)

extern "C" { __declspec(dllexport) extern const UINT D3D12SDKVersion = 618; }

extern "C" { __declspec(dllexport) extern const UINT D3D12SDKVersion = 618; }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions