diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ea94b2678..152d426838 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -58,7 +58,6 @@ Legends: - Fixed code samples, such as in the "View code" dialog, titled "Javascript" instead of "JavaScript": common programming languages and their aliases, such as `js`, now show their proper names, which can be overridden via `overrideLocalizedStrings` (`PROGRAMMING_LANGUAGE_*`), in PR [#5896](https://github.com/microsoft/BotFramework-WebChat/pull/5896), by [@OEvgeny](https://github.com/OEvgeny) - Fixed code not being highlighted when the programming language is not in lowercase, such as `TS`, in PR [#5896](https://github.com/microsoft/BotFramework-WebChat/pull/5896), by [@OEvgeny](https://github.com/OEvgeny) - Fixed GIFs in animation cards looping with no way to stop them: they now have a pause button, and do not play when the user prefers reduced motion or the card has `autostart: false`; the icons of the Copy and View code buttons are now visible in forced colors, fixes [#5734](https://github.com/microsoft/BotFramework-WebChat/issues/5734), in PR [#5897](https://github.com/microsoft/BotFramework-WebChat/pull/5897), by [@OEvgeny](https://github.com/OEvgeny) -- Fixed the play, mute, and "more options" icons of audio players being invisible in dark high contrast themes, such as "Aquatic" on Windows, fixes [#5710](https://github.com/microsoft/BotFramework-WebChat/issues/5710), in PR [#5906](https://github.com/microsoft/BotFramework-WebChat/pull/5906), by [@OEvgeny](https://github.com/OEvgeny) - Fixed the "Positive" card action button having less than 4.5:1 color contrast, fixes [#5713](https://github.com/microsoft/BotFramework-WebChat/issues/5713), in PR [#5905](https://github.com/microsoft/BotFramework-WebChat/pull/5905), by [@OEvgeny](https://github.com/OEvgeny) - Fixed screen readers announcing a single audio, video, or animation in a card as a list item, such as "1 of 1", fixes [#5722](https://github.com/microsoft/BotFramework-WebChat/issues/5722), in PR [#5903](https://github.com/microsoft/BotFramework-WebChat/pull/5903), by [@OEvgeny](https://github.com/OEvgeny) - Fixed video and animation cards disappearing in production builds when the video URL is relative or invalid, in PR [#5889](https://github.com/microsoft/BotFramework-WebChat/pull/5889), by [@OEvgeny](https://github.com/OEvgeny) diff --git a/__tests__/html2/attachment/audio.forcedColors.dark.html b/__tests__/html2/attachment/audio.forcedColors.dark.html deleted file mode 100644 index 5d7713aea0..0000000000 --- a/__tests__/html2/attachment/audio.forcedColors.dark.html +++ /dev/null @@ -1,79 +0,0 @@ - - - - - - -
- - - - diff --git a/__tests__/html2/attachment/audio.forcedColors.dark.html.snap-1.png b/__tests__/html2/attachment/audio.forcedColors.dark.html.snap-1.png deleted file mode 100644 index dec4ad61f7..0000000000 Binary files a/__tests__/html2/attachment/audio.forcedColors.dark.html.snap-1.png and /dev/null differ diff --git a/__tests__/html2/attachment/video.forcedColors.dark.html b/__tests__/html2/attachment/video.forcedColors.dark.html deleted file mode 100644 index 4f4eb311ca..0000000000 --- a/__tests__/html2/attachment/video.forcedColors.dark.html +++ /dev/null @@ -1,80 +0,0 @@ - - - - - - -
- - - - diff --git a/__tests__/html2/attachment/video.forcedColors.dark.html.snap-1.png b/__tests__/html2/attachment/video.forcedColors.dark.html.snap-1.png deleted file mode 100644 index 8b3ec78a68..0000000000 Binary files a/__tests__/html2/attachment/video.forcedColors.dark.html.snap-1.png and /dev/null differ diff --git a/packages/component/src/Styles/StyleSet/AudioContent.ts b/packages/component/src/Styles/StyleSet/AudioContent.ts index 02b8cdbc7b..d8b8dc6a2a 100644 --- a/packages/component/src/Styles/StyleSet/AudioContent.ts +++ b/packages/component/src/Styles/StyleSet/AudioContent.ts @@ -1,13 +1,5 @@ -import { FORCED_COLORS_SELECTOR } from './Constants'; - export default function AudioContent() { return { - width: '100%', - - // Chromium picks the player icons by the color scheme of the element, not by the forced colors palette, so dark palettes (e.g. "Aquatic" on Windows) get dark icons. - // TODO: Remove when Chromium is fixed, https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/media_controls/resources/mediaControls.css. - [FORCED_COLORS_SELECTOR]: { - colorScheme: 'light dark' - } + width: '100%' }; } diff --git a/packages/component/src/Styles/StyleSet/VideoContent.ts b/packages/component/src/Styles/StyleSet/VideoContent.ts index 8ade197d13..9c23dcda52 100644 --- a/packages/component/src/Styles/StyleSet/VideoContent.ts +++ b/packages/component/src/Styles/StyleSet/VideoContent.ts @@ -1,15 +1,8 @@ import { StrictStyleOptions } from 'botframework-webchat-api'; -import { FORCED_COLORS_SELECTOR } from './Constants'; - export default function createVideoContentStyle({ videoHeight }: StrictStyleOptions) { return { height: videoHeight, - width: '100%', - - // Without a video track (e.g. a voice message), Chromium shows the controls of the audio player, which need the same workaround as `AudioContent`. - [FORCED_COLORS_SELECTOR]: { - colorScheme: 'light dark' - } + width: '100%' }; }