From 9ae84aef1e46bbe1aa44b0d665f52ea874085058 Mon Sep 17 00:00:00 2001 From: speak-agent Date: Thu, 27 Aug 2026 23:39:22 +0800 Subject: [PATCH] Name the conformance section that exists, not one that does not MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ⚠️ `src/exec.cpp' said "tests/conformance_exec.cpp is where that distinction stops being an argument". That path is in THIS repository and there is no such file: the section is the specification's, at `conformance/src/sections/exec.cpp', and this package reaches it through `run-conformance.sh openkal-macos . full,optional'. A comment naming the place a question is answered is a promise. One pointing at nothing sends a reader to look and leaves them unable to tell whether the check is missing or the reference is --- which is the same defect musl/PATCHES.md was just corrected for, found by reading every file path the new comments name. --- src/exec.cpp | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/exec.cpp b/src/exec.cpp index 34625d7..994d3c3 100644 --- a/src/exec.cpp +++ b/src/exec.cpp @@ -20,14 +20,24 @@ // SAME TIME --- `MAP_JIT' and the pair of calls that flip one region between // the two. It is not what a program needs to obtain memory that is writable, // then made executable and no longer writable, which is the whole of what this -// interface offers. tests/conformance_exec.cpp is where that distinction stops -// being an argument: it reserves a region, writes an instruction sequence into -// it, publishes it, CALLS it, and compares what it returned. +// interface offers. // -// ⇒ If that test fails on this system, the reading above is wrong and the +// ⭐ THE SPECIFICATION'S OWN SUITE IS WHERE THAT DISTINCTION STOPS BEING AN +// ARGUMENT --- `conformance/src/sections/exec.cpp' in the openkal repository, +// which this package runs through `run-conformance.sh openkal-macos . +// full,optional'. It reserves a region, writes an instruction sequence into it, +// publishes it, CALLS it, and compares what it returned. +// +// ⚠️ An earlier version of this comment named `tests/conformance_exec.cpp', +// which is in this repository and does not exist. A comment naming the place a +// question is answered is a promise, and one pointing at nothing sends a reader +// to look and leaves them unable to tell whether the check is missing or the +// reference is. +// +// ⇒ If that section fails on this system, the reading above is wrong and the // remedy is clause 6.5's: a feature of this package, provided at dependency -// resolution, together with whatever produces the artifact. The test is here so -// that the question is answered by the system rather than by this comment. +// resolution, together with whatever produces the artifact. The question is +// answered by the system rather than by this comment. // // ⚠️⚠️ THE INSTRUCTION CACHE IS NOT INVALIDATED HERE, AND ONE VERSION OF THIS // FILE DID INVALIDATE IT. THE MEASUREMENT IS WHY IT DOES NOT.