Commit 270bd92
committed
fix(bench): the same rewrite broke a third check — now there is a guard
`linux/clang/fixture` 84 ok / 6 failed:
g++: error: unrecognized command-line option '--no-default-config'
clang 格子里 xmake 用了 **g++**,而描述里写的是 clang 的 flags。成因和我上一个
提交修的 `payload_toolchain` **一模一样**:main.cpp 把 `--compiler payload:clang`
改写成绝对路径后,`job.compiler == "clang"` 在**恰恰需要它为真的那些格子里**永远
为假,于是 `--toolchain=llvm` 没传,xmake 回落到默认编译器。
**我上次只修了一处,没有回头查还有谁在比同一个字符串。** 这是同一个改写第三次
咬人,每次在 review 里都读着像对的 —— 因为被比较的正是用户敲进去的那个词。
所以补的不只是那一行,还有 e2e 233 §7:**禁止任何引擎适配器按字面量比较
`job.compiler`**(`engine.cppm` 的 `resolve_cxx` 除外 —— 它是入口归一化,在改写
之前运行)。判据剔除注释行,两个方向都验过:改回字面量比较会红,还原后绿。1 parent 1f4552e commit 270bd92
2 files changed
Lines changed: 48 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
157 | 167 | | |
158 | 168 | | |
159 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
400 | 437 | | |
0 commit comments