Satisfy receipt style rules without changing qualification behavior

Author: KSemenenko

tests/KeyLoad.SiteTests/Features/BenchmarkComparisons/SiteIsolatedGitHubArchiveReceipt.cs

@@ -5,29 +5,21 @@ namespace KeyLoad.SiteTests.Features.BenchmarkComparisons;
 
 internal sealed record SiteIsolatedGitHubArchiveFile(string Path, long Bytes, string Sha256);
 
-internal sealed class SiteIsolatedGitHubArchiveReceipt
+internal sealed class SiteIsolatedGitHubArchiveReceipt(string capture, string receiptPath,
+    JsonObject value, SiteIsolatedGitHubArchiveFile[] files)
 {
-    private readonly JsonObject originalValue;
-    private readonly SiteIsolatedGitHubArchiveFile[] originalFiles;
+    private JsonObject OriginalValue { get; } = value.DeepClone().AsObject();
+    private SiteIsolatedGitHubArchiveFile[] OriginalFiles { get; } = [.. files];
 
-    public SiteIsolatedGitHubArchiveReceipt(string capture, string receiptPath,
-        JsonObject value, SiteIsolatedGitHubArchiveFile[] files)
-    {
-        Capture = capture;
-        ReceiptPath = receiptPath;
-        originalValue = value.DeepClone().AsObject();
-        originalFiles = [.. files];
-    }
-
-    public string Capture { get; }
+    public string Capture { get; } = capture;
 
-    public string ReceiptPath { get; }
+    public string ReceiptPath { get; } = receiptPath;
 
-    public JsonObject Value => originalValue.DeepClone().AsObject();
+    public JsonObject Value => OriginalValue.DeepClone().AsObject();
 
-    public SiteIsolatedGitHubArchiveFile[] Files => [.. originalFiles];
+    public SiteIsolatedGitHubArchiveFile[] Files => [.. OriginalFiles];
 
-    internal bool Matches(JsonNode? value) => JsonNode.DeepEquals(originalValue, value);
+    internal bool Matches(JsonNode? value) => JsonNode.DeepEquals(OriginalValue, value);
 }
 
 internal static class SiteIsolatedGitHubReceiptReader

zonetree-orleans-wal.plan.md

@@ -127,3 +127,8 @@ Root source/branch/lifetime/privacy review, normal enabled Release builds, scope
 
 
 Final prerequisite source review keeps all RPC outcomes/privacy, native Neo4j mismatch/restore/report assertions and original RF3 budgets. The enabled comparison Release build passes0warnings/0errors after sole-client ownership transfer and layered await-using scopes; the six owned files pass required formatter verification, and static governance/diff checks pass. The full dirty solution's Unit/Integration/Comparison projects build; final solution result fails only two concurrent SiteIsolatedGitHubArchiveAuthorityTests MatchesBytes diagnostics outside this scope. No local tests ran, and this is not full runtime qualification. The nine-file stable WAL gate checkpoint excludes every concurrent Site/isolated-comparison file; complete new-source GitHub build/unit/scalar/recovery/RF3 remains required, with the Series safe response diagnostic retained for any repeated failure.
+
+
+## Mechanical Site build prerequisite
+
+Exactcfe8c1608/run37083535329 enabled GitHub build fails only SiteIsolatedGitHubArchiveReceipt.cs IDE0032/IDE0290; native analyzer118 gate passes and RF3 runs independently. TASK-WAL-CI-STYLE under WAL005 changes only that committed receipt class to the required primary constructor/get-only backing properties, preserving constructor parameter order, exact DeepClone/copy-on-access and Matches behavior. Root prepares an exactHEAD index patch so the active owner's different receipt/authority/MatchesBytes work stays visible and unstaged. No behavior/API/security/test assertion changes, new runtime tests or ADR: N/A for mechanical style. Source/formatter/governance review and full next-source GitHub gate remain mandatory; skipped unit/recovery/comparison after failed build are not passing evidence.