Repair original Linux benchmark qualification failures

Author: KSemenenko

benchmarks/KeyLoad.Comparisons/Features/BenchmarkComparisons/Targets/MongoDB/MongoProfileFactory.cs

@@ -1,5 +1,5 @@
-using MongoDB.Driver;
 using Microsoft.Extensions.Options;
+using MongoDB.Driver;
 
 namespace KeyLoad.Comparisons.Targets;
 

docs/implementation/status.json

@@ -25,15 +25,30 @@
     "websiteBaselineInputs": 1716,
     "runtimeQualified": false,
     "fullTaskComplete": false,
-    "sourceStage": "Shared native runner/adapters, exclusive RF3 load and authenticated qualification implemented; mapped regression repairs frozen for a scoped GitHub checkpoint. Owner correction requires all further builds, checks and tests in GitHub Actions.",
+    "sourceStage": "Shared native runner/adapters, exclusive RF3 load and authenticated qualification implemented in checkpoint 59e393f4. Original Linux build passed; import ordering and two exact Aspire registry assertions repaired for the next GitHub checkpoint. Heavy-load overlap proof now observes the incomplete writer before the later incomplete read. All further builds, checks and tests remain GitHub-only.",
     "verification": {
-      "canonicalBuild": "github_checkpoint_pending; earlier local tenth build compiled ComparisonTests but failed on heavy lifecycle and concurrent recovery sources; mapped owning repairs authored",
-      "format": "github_canonical_verification_pending; earlier scoped whitespace and braces applied",
-      "governance": "github_checkpoint_pending; earlier development check passed before final repairs",
-      "nativeRegressions": "github_checkpoint_pending; earlier local original TUnit 136/152 passed, 16 failed, zero skipped; mapped fixture/configuration/cleanup repairs authored",
+      "canonicalBuild": "original_linux_59e393f4_passed_in_benchmarks_and_build_and_tests; next_repaired_source_pending",
+      "format": "original_linux_59e393f4_failed_one_MongoProfileFactory_IMPORTS_ordering; exact_import_repair_authored_next_source_pending",
+      "governance": "original_linux_59e393f4_build_and_tests_repository_rules_passed; benchmark_gate_not_reached_after_format_failure",
+      "nativeRegressions": "original_linux_59e393f4_resource_models_105_passed_2_failed_0_skipped; exact_HelixDB_SurrealDB_Registry_null_assertions_repaired; document_native_and_heavy_gates_not_reached; earlier_local_136_of_152_failed_history_retained",
       "actualLinuxScale": "pending_original_exact_source_workflow",
-      "workflowSyntax": "github_checkpoint_pending; earlier actionlint passed after functional gate join",
-      "canonicalPlanner": "418_documents_and_1898_total_named_database_cells_generated"
+      "workflowSyntax": "original_linux_59e393f4_workflow_started_and_plan_passed; next_source_pending",
+      "canonicalPlanner": "original_linux_59e393f4_plan_passed_418_documents_and_1898_total_named_database_cells"
+    },
+    "latestOriginalLinux": {
+      "sourceCommit": "59e393f43f7c8f3bddd72125aeebb5f8304af5ab",
+      "runId": 37918202699,
+      "runAttempt": 1,
+      "receipt": "https://github.com/managedcode/KeyLoad/actions/runs/37918202699",
+      "conclusion": "failure",
+      "buildPassed": true,
+      "formatterPassed": false,
+      "resourceModelPassed": 105,
+      "resourceModelFailed": 2,
+      "resourceModelSkipped": 0,
+      "documentNativeExecuted": false,
+      "heavyRf3Executed": false,
+      "scaleExecuted": false
     },
     "qualification": "No fabricated measurements, no performance winner, no full coverage or production claim; authentic complete current-source Linux workloads and required recovery/RF3 gates remain open."
   },

tests/KeyLoad.ComparisonTests/Features/BenchmarkComparisons/Cases/IsolatedHelixDbResourceTests.cs

@@ -17,7 +17,7 @@ public async Task HelixDbUsesPinnedServerWithNativeDirectoryPersistence()
         var runner = resources.Single(item => item.Name == IsolatedResourceTopologyFixture.RunnerName);
         await IsolatedResourceTopologyFixture.VerifyWaitsAsync(runner, [node]);
         var image = node.Annotations.OfType<ContainerImageAnnotation>().Single();
-        await Assert.That(image.Registry).IsEqualTo(string.Empty);
+        await Assert.That(image.Registry).IsNull();
         await Assert.That(image.Image).IsEqualTo("ghcr.io/helixdb/helixdb");
         await Assert.That(image.Tag).IsNull();
         await Assert.That(image.SHA256).IsEqualTo(BenchmarkResources.HelixDbDigest[7..]);

tests/KeyLoad.ComparisonTests/Features/BenchmarkComparisons/Cases/IsolatedSurrealDbResourceTests.cs

@@ -41,7 +41,7 @@ public async Task SurrealDbDoesNotInventCommunityClusterMembers(int count)
     internal static async Task VerifyNodeAsync(ContainerResource node, string root)
     {
         var image = node.Annotations.OfType<ContainerImageAnnotation>().Single();
-        await Assert.That(image.Registry).IsEqualTo(string.Empty);
+        await Assert.That(image.Registry).IsNull();
         await Assert.That(image.Image).IsEqualTo("surrealdb/surrealdb");
         await Assert.That(image.Tag).IsNull();
         await Assert.That(image.SHA256).IsEqualTo(BenchmarkResources.SurrealDbDigest[7..]);

tests/KeyLoad.IntegrationTests/Features/DocumentStorage/Helpers/HeavyDocumentLoadScenario.cs

@@ -114,7 +114,8 @@ private async Task ReadSdkAsync(KeyLoadClient client, PartitionRef partition, Ca
         {
             token.ThrowIfCancellationRequested();
             var original = client.GetAsync(HeavyDocumentLoadReadback.Sentinel(partition), token);
-            var concurrent = !original.IsCompleted && overlap.HasIncompleteOriginal();
+            // Completion is monotonic: a later incomplete read also existed at the observed incomplete write.
+            var concurrent = overlap.HasIncompleteOriginal() && !original.IsCompleted;
             var result = await McpCallerAssertions.SdkSuccessAsync(await original.ConfigureAwait(false)).ConfigureAwait(false);
             await HeavyDocumentLoadReadback.VerifySentinelAsync(result, partition).ConfigureAwait(false);
             if (concurrent)
@@ -129,7 +130,7 @@ private async Task ReadMcpAsync(McpOfficialClient owner, PartitionRef partition,
             token.ThrowIfCancellationRequested();
             var original = owner.CallAsync(McpCallerTools.DocumentsGet,
                 new GetDocumentRequest(HeavyDocumentLoadReadback.Sentinel(partition)), token);
-            var concurrent = !original.IsCompleted && overlap.HasIncompleteOriginal();
+            var concurrent = overlap.HasIncompleteOriginal() && !original.IsCompleted;
             var result = await McpCallerAssertions.SuccessAsync<DocumentResult?>(await original.ConfigureAwait(false))
                 .ConfigureAwait(false);
             await HeavyDocumentLoadReadback.VerifySentinelAsync(result.Value, partition).ConfigureAwait(false);
@@ -145,7 +146,7 @@ private async Task QueryMcpAsync(McpOfficialClient owner, PartitionRef partition
         {
             token.ThrowIfCancellationRequested();
             var original = owner.CallAsync(McpCallerTools.QueryAst, request, token);
-            var concurrent = !original.IsCompleted && overlap.HasIncompleteOriginal();
+            var concurrent = overlap.HasIncompleteOriginal() && !original.IsCompleted;
             var result = await McpCallerAssertions.SuccessAsync<QueryPage>(await original.ConfigureAwait(false))
                 .ConfigureAwait(false);
             await HeavyDocumentLoadReadback.VerifySentinelPageAsync(result.Value).ConfigureAwait(false);