You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 156d732
Browse filesBrowse the repository at this point in the historyBrowse files
Accepted bounded stage: REQ/AC-ANN-016 and TASK-ANN-DUPLICATE-BUDGET-CHECKS in `REQ-AC-ANN-016.md`.
156
+
157
+
`AnnWorkBudget.Charge` begins by calling `Check`, then validates the charge and updates the existing work counter. In eight frozen Search source files, twelve sites call `Check` immediately before `Charge` with no intervening operation. Remove only those twelve calls. Retain every `Charge` and its original amount, so each charged action still observes cancellation/deadline immediately before its counter update. Preserve other explicit checks, particularly any path that can exit without reaching a charge.
158
+
159
+
The Luna worker owns only the eight listed ANN source files in the private packet. Root owns exact-base review, integration, strict checks, and same-source genuine Aspire normal/scalar observations with no changes to the corpus, caps, deadline, test admission, or assertions. This is an equivalent-check-count optimization candidate, not a measured speedup, timeout diagnosis, or qualification. Rollback restores the eight source files. Persistence, public transport, storage, and migration are N/A.
160
+
161
+
162
+
## Accepted ADR-019 amendment — charged ANN inner-loop check de-duplication
163
+
164
+
Candidate stage REQ/AC-ANN-017 / TASK-ANN-INNERLOOP-CHECKS in
165
+
`REQ-AC-ANN-017.md`.
166
+
167
+
The 10k Build report records 165M work units, 4.37M distances and 12.41M edge
168
+
visits, but does not attribute their per-method source or prove the original
Enter, the exact selected value and independent row oracle intact.
529
+
5. Root reviews the complete packet and immutable hashes, joins it, then runs
530
+
the actual Aspire-owned strict build/format/governance and full TUnit/site /
531
+
Chrome / native coverage gates. Browser resource admission alone makes no
532
+
speed claim and does not diagnose the original keyboard miss.
533
+
534
+
Rollback restores the owned helper/callers/test and their contract together;
535
+
there is no product, persisted-data, dependency, website rendering, workflow or
536
+
publication migration.
537
+
538
+
# Proposed ADR-040 r2 amendment — original waiter withdrawal oracle
539
+
540
+
Accepted candidate delta: REQ/AC-BC-CHROME-001 clarification and bounded
541
+
waiter-membership oracle in `REQ-AC-r2-amendment.md`.
542
+
543
+
The current native `SiteHeavyChildAdmission.Waiter` already stores the original
544
+
caller token and the pending `LinkedList<Waiter>` is bounded to 64. Add only an
545
+
internal read-only method that scans that list under its existing `_sync` lock
546
+
for `CancellationToken.Equals` against the supplied unique linked token. The
547
+
browser-specific `SiteBrowserSessionAdmission` wrapper is the only caller/API
548
+
surface. The observation creates no new queue, registry, subscription, retained
549
+
identity, timing mechanism or diagnostic output and does not change how waiters
550
+
are admitted, cancelled, withdrawn, granted or rejected. The scan is bounded by
551
+
the already enforced queue cap.
552
+
553
+
The real Chrome test asserts that its exact token is in the pending queue
554
+
before cancellation and absent after the actual canceled acquisition has
555
+
settled with the original token. Preserve aggregate counts and all real Chrome,
556
+
CDP, coverage and original-process ownership checks from r1. No global
557
+
serialization or weakened acceptance is introduced.
558
+
559
+
Implementation owns only the native helper, browser wrapper and existing
560
+
browser lifecycle case enumerated in the feature amendment. Root owns review,
561
+
join and actual Aspire/browser verification. Rollback removes only the
562
+
observation and its exact test assertions. The observer proves membership and
563
+
withdrawal for that token; it does not claim concurrent-launch performance,
564
+
keyboard root cause or CI qualification.
565
+
566
+
567
+
### Browser lease transfer at factory return
568
+
569
+
The reviewed browser session factory admits one actual browser lease before the version child, endpoint/Chrome startup and CDP/coverage setup. Its lexical `using` owns all failure paths. Immediately before a successful return it marks that same lease transferred to the returned native process owner; only the factory's scope disposal consumes this transfer marker, leaving the actual lease held until the returned owner settles its original process, CDP and HTTP resources. Existing non-browser callers never set this marker. This is an ownership-transfer marker, not a readiness, exit or coverage proof. Failed setup follows the existing resource joins and bounded pool poison rule. AC-ISO-009's real cancellation/successor/native PID regression remains the evidence; the keyboard assertion retains its exact predicate and prints only bounded observed failure diagnostics through native TUnit output.
0 commit comments