Stabilize exact CLI release qualification

Author: KSemenenko

.github/workflows/ci.yml

@@ -38,7 +38,16 @@ jobs:
       - name: Install Codex CLI
         shell: bash
         run: |
-          npm install --no-save @openai/codex
+          set -euo pipefail
+          target_version="$(sed -nE 's/^[[:space:]]*public const string TargetVersion = "([0-9]+\.[0-9]+\.[0-9]+)";$/\1/p' CodexSharpSDK/Models/CodexCliCompatibility.cs)"
+          [[ -n "$target_version" && "$target_version" != *$'\n'* ]] || { echo "Expected exactly one three-part Codex CLI TargetVersion."; exit 1; }
+          npm install --no-save "@openai/codex@$target_version"
+          export PATH="$GITHUB_WORKSPACE/node_modules/.bin:$PATH"
+          version="$(codex --version)"
+          printf '%s\n' "$version"
+          actual_version="$(printf '%s\n' "$version" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | sed -n '1p')"
+          printf 'Installed Codex CLI version: %s\n' "$actual_version"
+          [[ "$actual_version" == "$target_version" ]]
           echo "$GITHUB_WORKSPACE/node_modules/.bin" >> "$GITHUB_PATH"
 
       - name: Restore

.github/workflows/codex-cli-watch.yml

@@ -155,10 +155,10 @@ jobs:
 
           cli_changed_files="$(printf '%s\n' "$changed_files" | grep -E '^(codex-rs/|docs/|README\.md|CHANGELOG\.md|Cargo\.toml|Cargo\.lock|package\.json)' || true)"
           if [ -z "$cli_changed_files" ]; then
-            cli_changed_files="$(printf '%s\n' "$changed_files" | head -n 200)"
+            cli_changed_files="$(printf '%s\n' "$changed_files" | sed -n '1,200p')"
           fi
 
-          commits="$(git -C "$SUBMODULE_PATH" log --no-merges --date=short --pretty=format:'- %h %s (%ad)' "$current_sha..$latest_sha" | head -n 100)"
+          commits="$(git -C "$SUBMODULE_PATH" log --no-merges --max-count=100 --date=short --pretty=format:'- %h %s (%ad)' "$current_sha..$latest_sha")"
           if [ -z "$commits" ]; then
             commits='- No commit summary available.'
           fi

.github/workflows/real-integration.yml

@@ -38,7 +38,18 @@ jobs:
           dotnet-version: ${{ env.DOTNET_VERSION }}
 
       - name: Install Codex CLI
-        run: npm install --no-save @openai/codex
+        shell: bash
+        run: |
+          set -euo pipefail
+          target_version="$(sed -nE 's/^[[:space:]]*public const string TargetVersion = "([0-9]+\.[0-9]+\.[0-9]+)";$/\1/p' CodexSharpSDK/Models/CodexCliCompatibility.cs)"
+          [[ -n "$target_version" && "$target_version" != *$'\n'* ]] || { echo "Expected exactly one three-part Codex CLI TargetVersion."; exit 1; }
+          npm install --no-save "@openai/codex@$target_version"
+          export PATH="$GITHUB_WORKSPACE/node_modules/.bin:$PATH"
+          version="$(codex --version)"
+          printf '%s\n' "$version"
+          actual_version="$(printf '%s\n' "$version" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | sed -n '1p')"
+          printf 'Installed Codex CLI version: %s\n' "$actual_version"
+          [[ "$actual_version" == "$target_version" ]]
 
       - name: Restore
         run: dotnet restore ManagedCode.CodexSharpSDK.slnx

.github/workflows/release.yml

@@ -87,8 +87,18 @@ jobs:
         node-version: ${{ env.NODE_VERSION }}
 
     - name: Install Codex CLI
+      shell: bash
       run: |
-        npm install --no-save @openai/codex
+        set -euo pipefail
+        target_version="$(sed -nE 's/^[[:space:]]*public const string TargetVersion = "([0-9]+\.[0-9]+\.[0-9]+)";$/\1/p' CodexSharpSDK/Models/CodexCliCompatibility.cs)"
+        [[ -n "$target_version" && "$target_version" != *$'\n'* ]] || { echo "Expected exactly one three-part Codex CLI TargetVersion."; exit 1; }
+        npm install --no-save "@openai/codex@$target_version"
+        export PATH="$GITHUB_WORKSPACE/node_modules/.bin:$PATH"
+        version="$(codex --version)"
+        printf '%s\n' "$version"
+        actual_version="$(printf '%s\n' "$version" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | sed -n '1p')"
+        printf 'Installed Codex CLI version: %s\n' "$actual_version"
+        [[ "$actual_version" == "$target_version" ]]
         echo "$GITHUB_WORKSPACE/node_modules/.bin" >> "$GITHUB_PATH"
 
     - name: Extract version from Directory.Build.props

CodexSharpSDK.Tests/Unit/CliInstallationTests.cs

@@ -82,20 +82,27 @@ public sealed class CliInstallationTests
         const shim = process.platform === 'win32' ? '@echo off\r\n' : `#!/bin/sh\nexec ${shellQuote(process.execPath)} ${shellQuote(path.join(packageRoot, 'PACKAGE_ENTRY'))} "$@"\n`;
         fs.writeFileSync(shimPath, shim);
         if (process.platform !== 'win32') fs.chmodSync(shimPath, 0o755);
+        function writeProcessId(filePath) {
+            const temporaryPath = filePath + '.tmp';
+            fs.writeFileSync(temporaryPath, String(process.pid));
+            fs.renameSync(temporaryPath, filePath);
+        }
         if (fs.existsSync(path.join(__dirname, 'hang'))) {
-            fs.writeFileSync(path.join(__dirname, 'child.pid'), String(process.pid));
+            writeProcessId(path.join(__dirname, 'child.pid'));
             setInterval(() => {}, 1000);
         }
         if (fs.existsSync(path.join(__dirname, 'pipe-holder'))) {
-            const { spawnSync } = require('node:child_process');
-            const shellCommand = `setsid /bin/sh -c 'echo $$ > ${shellQuote(path.join(__dirname, 'pipe-holder.pid'))}; exec /bin/sleep 60' holder &`;
-            spawnSync('/bin/sh', ['-c', shellCommand], { stdio: 'inherit' });
+            const { spawn } = require('node:child_process');
+            const childScript = 'printf "%s" "$$" > "$1.tmp" && mv "$1.tmp" "$1" && exec /bin/sleep 60';
+            const holder = spawn('setsid', ['/bin/sh', '-c', childScript, 'holder',
+                path.join(__dirname, 'pipe-holder.pid')], { detached: true, stdio: 'inherit' });
+            holder.unref();
         }
         if (fs.existsSync(path.join(__dirname, 'overflow'))) {
             process.stdout.write('x'.repeat(8192));
             setInterval(() => {}, 1000);
         }
-        fs.writeFileSync(path.join(__dirname, 'child.pid'), String(process.pid));
+        writeProcessId(path.join(__dirname, 'child.pid'));
         console.log('installation output');
         console.error('installation diagnostics');
         """;
@@ -176,9 +183,7 @@ public async Task InstallOrUpdate_ReportsFinalOutputWhenConsumerResumesAfterProc
             await Assert.That(updates.Current.Stage).IsEqualTo(CliInstallationStage.PackageManagerStarted);
             var childPidPath = Path.Combine(fixture.NpmRoot, BinDirectoryName, ChildPidFileName);
             using var markerTimeout = new CancellationTokenSource(TimeSpan.FromSeconds(3));
-            await WaitForFileAsync(childPidPath, markerTimeout.Token);
-            var childPid = int.Parse(await File.ReadAllTextAsync(childPidPath),
-                System.Globalization.CultureInfo.InvariantCulture);
+            var childPid = await WaitForProcessIdAsync(childPidPath, markerTimeout.Token);
             await WaitForProcessExitAsync(childPid, markerTimeout.Token);
 
             var sawFinalOutput = false;
@@ -219,9 +224,7 @@ public async Task InstallOrUpdate_EnforcesTimeoutWhileConsumerIsPausedAfterStart
             await Assert.That(updates.Current.Stage).IsEqualTo(CliInstallationStage.PackageManagerStarted);
 
             using var deadline = new CancellationTokenSource(TimeSpan.FromSeconds(5));
-            await WaitForFileAsync(childPidPath, deadline.Token);
-            var childPid = int.Parse(await File.ReadAllTextAsync(childPidPath),
-                System.Globalization.CultureInfo.InvariantCulture);
+            var childPid = await WaitForProcessIdAsync(childPidPath, deadline.Token);
             await WaitForProcessExitAsync(childPid, deadline.Token);
             await Assert.That(IsProcessRunning(childPid)).IsFalse();
 
@@ -266,12 +269,8 @@ await File.WriteAllTextAsync(Path.Combine(fixture.NpmRoot, BinDirectoryName, Pip
                 fixture.LocalApplicationDataRoot, CancellationToken.None).GetAsyncEnumerator();
             await Assert.That(await updates.MoveNextAsync()).IsTrue();
             using var markerTimeout = new CancellationTokenSource(TimeSpan.FromSeconds(3));
-            await WaitForFileAsync(rootPidFile, markerTimeout.Token);
-            await WaitForFileAsync(holderPidFile, markerTimeout.Token);
-            var rootPid = int.Parse(await File.ReadAllTextAsync(rootPidFile),
-                System.Globalization.CultureInfo.InvariantCulture);
-            holderPid = int.Parse(await File.ReadAllTextAsync(holderPidFile),
-                System.Globalization.CultureInfo.InvariantCulture);
+            var rootPid = await WaitForProcessIdAsync(rootPidFile, markerTimeout.Token);
+            holderPid = await WaitForProcessIdAsync(holderPidFile, markerTimeout.Token);
             await WaitForProcessExitAsync(rootPid, markerTimeout.Token);
             await Assert.That(IsProcessRunning(rootPid)).IsFalse();
             await Assert.That(IsProcessRunning(holderPid)).IsTrue();
@@ -350,7 +349,7 @@ public async Task InstallOrUpdate_CancellationStopsAndJoinsPackageManager()
                 await Task.Delay(TimeSpan.FromMilliseconds(10), markerTimeout.Token);
             }
 
-            var childPid = int.Parse(await File.ReadAllTextAsync(childPidPath), System.Globalization.CultureInfo.InvariantCulture);
+            var childPid = await WaitForProcessIdAsync(childPidPath, markerTimeout.Token);
             var competingOptions = fixture.Options with { InstallationLockTimeout = TimeSpan.FromMilliseconds(100) };
             var lockException = await Assert.That(async () =>
                 await RunInstallationAsync(fixture, competingOptions)).ThrowsException();
@@ -403,12 +402,8 @@ public async Task CancellationWithDetachedPipeHolderSurfacesUnconfirmedCleanup()
                 fixture.LocalApplicationDataRoot, cancellation.Token).GetAsyncEnumerator();
             await Assert.That(await updates.MoveNextAsync()).IsTrue();
             using var markerTimeout = new CancellationTokenSource(TimeSpan.FromSeconds(3));
-            await WaitForFileAsync(packageManagerPidFile, markerTimeout.Token);
-            await WaitForFileAsync(holderPidFile, markerTimeout.Token);
-            var packageManagerPid = int.Parse(await File.ReadAllTextAsync(packageManagerPidFile),
-                System.Globalization.CultureInfo.InvariantCulture);
-            holderProcessId = int.Parse(await File.ReadAllTextAsync(holderPidFile),
-                System.Globalization.CultureInfo.InvariantCulture);
+            var packageManagerPid = await WaitForProcessIdAsync(packageManagerPidFile, markerTimeout.Token);
+            holderProcessId = await WaitForProcessIdAsync(holderPidFile, markerTimeout.Token);
             await Assert.That(IsProcessRunning(packageManagerPid)).IsTrue();
             await Assert.That(IsProcessRunning(holderProcessId)).IsTrue();
 
@@ -510,10 +505,20 @@ private static string FindExecutablePath(string executableName)
         return Path.GetFullPath(executable ?? throw new InvalidOperationException(SetsidRequiredMessage));
     }
 
-    private static async Task WaitForFileAsync(string path, CancellationToken cancellationToken)
+    private static async Task<int> WaitForProcessIdAsync(string path, CancellationToken cancellationToken)
     {
-        while (!File.Exists(path))
+        while (true)
         {
+            if (File.Exists(path))
+            {
+                var contents = await File.ReadAllTextAsync(path, cancellationToken);
+                if (int.TryParse(contents, System.Globalization.CultureInfo.InvariantCulture, out var processId) &&
+                    processId > 0)
+                {
+                    return processId;
+                }
+            }
+
             await Task.Delay(TimeSpan.FromMilliseconds(10), cancellationToken);
         }
     }