From 8bafe0d7311715179943076db024cc8944e79195 Mon Sep 17 00:00:00 2001
From: Anik Bhattacharjee <anbhatta@redhat.com>
Date: Fri, 30 Oct 2026 16:18:31 -0400
Subject: [PATCH] LCORE-5254: Fix Fullsend config parse break from retro
 trigger

PR [307(https://github.com/lightspeed-core/lightspeed-stack/pull/3074) added the retro /fs-retro trigger as a map entry under roles:,
but roles: only accepts plain strings, so the per-repo config fails to
parse (yaml: cannot unmarshal !!map into string). This breaks every
Fullsend agent run on main.

This PR fixes it by making the following changes:
- roles: restored to a plain string list
- retro registered in agents: with source: harness/retro.yaml
- harness/retro.yaml carries the /fs-retro-only trigger, extending the
  upstream agents v0.51.0 retro harness with SHA-256 integrity

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
---
 .fullsend/config.yaml        | 12 ++++++------
 .fullsend/harness/retro.yaml | 13 +++++++++++++
 2 files changed, 19 insertions(+), 6 deletions(-)
 create mode 100644 .fullsend/harness/retro.yaml

diff --git a/.fullsend/config.yaml b/.fullsend/config.yaml
index ad0e2b3bc..ac7d99dbd 100644
--- a/.fullsend/config.yaml
+++ b/.fullsend/config.yaml
@@ -10,12 +10,12 @@ roles:
     - coder
     - review
     - fix
-    - retro:
-        trigger: >
-          event.transition.kind == "comment_added"
-          && has(event.transition.comment.command)
-          && event.transition.comment.command == "/fs-retro"
-          && event.actor.kind == "human"
+    - retro
+agents:
+    # Retro: run only on an explicit /fs-retro comment from a human, not on
+    # every closed PR. 
+    - name: retro
+      source: harness/retro.yaml
 allowed_remote_resources:
     - https://raw.githubusercontent.com/fullsend-ai/fullsend/
     - https://raw.githubusercontent.com/fullsend-ai/agents/
diff --git a/.fullsend/harness/retro.yaml b/.fullsend/harness/retro.yaml
new file mode 100644
index 000000000..d5c2451cb
--- /dev/null
+++ b/.fullsend/harness/retro.yaml
@@ -0,0 +1,13 @@
+# Retro harness overlay for lightspeed-core/lightspeed-stack
+#
+# Extends the upstream fullsend-ai/agents retro harness (pinned to the v0.51.0
+# commit with a SHA-256 integrity fragment) and restricts dispatch to an
+# explicit /fs-retro comment from a human. By default retro runs on every
+# closed pull request; this overlay makes it opt-in only.
+base: https://raw.githubusercontent.com/fullsend-ai/agents/16657d540187b16743c8693dc2ccc40366334430/harness/retro.yaml#sha256=97771fd79ad7f4095b5fc9d92dc9d447487c19482018d2c9ccce1c4398608fd5
+
+trigger: >-
+  event.transition.kind == "comment_added"
+  && has(event.transition.comment.command)
+  && event.transition.comment.command == "/fs-retro"
+  && event.actor.kind == "human"