From 830558e5821cc332832f88e0c6e598fa7155f4b2 Mon Sep 17 00:00:00 2001 From: Anik Bhattacharjee Date: Thu, 29 Oct 2026 11:59:10 -0400 Subject: [PATCH] LCORE-5254: Restrict Fullsend review to explicit /fs-review comments Prevent the review agent from running automatically on PR open/push/ready events. Instead, only trigger review on explicit /fs-review comments from humans. This avoids automatic label additions that were re-triggering the E2E authorization workflow and causing e2e tests to skip on label events, since [existing e2e auth workflows expects an "ok-to-test" labels from repo maintainers](https://github.com/lightspeed-core/lightspeed-stack/blob/main/.github/workflows/e2e_authorize.yaml#L18) only. Addition of random labels by bot is causing the condition fail leading to skipping of e2e jobs. Implemented via documented CEL trigger from Fullsend config reference. https://fullsend.sh/docs/guides/user/customizing-agents#choosing-when-review-runs Signed-off-by: Anik Bhattacharjee --- .fullsend/config.yaml | 6 ++++++ .fullsend/harness/review.yaml | 14 ++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 .fullsend/harness/review.yaml diff --git a/.fullsend/config.yaml b/.fullsend/config.yaml index b6680d03d..b0c7ace07 100644 --- a/.fullsend/config.yaml +++ b/.fullsend/config.yaml @@ -10,6 +10,12 @@ roles: - coder - review - fix +agents: + # Review: run only on an explicit /fs-review comment from a human, not on + # every PR open/push/ready. A built-in agent trigger must be carried by a + # source overlay on the installed fullsend v0.51.0 CLI. + - name: review + source: harness/review.yaml allowed_remote_resources: - https://raw.githubusercontent.com/fullsend-ai/fullsend/ - https://raw.githubusercontent.com/fullsend-ai/agents/ diff --git a/.fullsend/harness/review.yaml b/.fullsend/harness/review.yaml new file mode 100644 index 000000000..21514c9a4 --- /dev/null +++ b/.fullsend/harness/review.yaml @@ -0,0 +1,14 @@ +# Review harness overlay for lightspeed-core/lightspeed-stack +# +# Extends the upstream fullsend-ai/agents review harness (pinned to the v0.51.0 +# commit with a SHA-256 integrity fragment) and restricts dispatch to an +# explicit /fs-review comment from a human. By default review runs on every PR +# open/push/ready; this overlay makes it opt-in only. +base: https://raw.githubusercontent.com/fullsend-ai/agents/16657d540187b16743c8693dc2ccc40366334430/harness/review.yaml#sha256=10a0d8a3c4f77ab89c4bd3cef5cead82d0680cc1f56965656a3c101aaf589a85 + +trigger: >- + event.transition.kind == "comment_added" + && has(event.entity.linked_change_proposal) + && has(event.transition.comment.command) + && event.transition.comment.command == "/fs-review" + && event.actor.kind == "human"