GGMLRunner: avoid multiple calls to get_graph#646
Open
idostyle wants to merge 1 commit into
Open
Conversation
roj234
added a commit
to roj234/stable-diffusion.cpp
that referenced
this pull request
Feb 3, 2026
roj234
added a commit
to roj234/stable-diffusion.cpp
that referenced
this pull request
Feb 21, 2026
roj234
added a commit
to roj234/stable-diffusion.cpp
that referenced
this pull request
Feb 21, 2026
(cherry picked from commit f48d7fc)
roj234
added a commit
to roj234/stable-diffusion.cpp
that referenced
this pull request
Feb 21, 2026
(cherry picked from commit f48d7fc)
roj234
added a commit
to roj234/stable-diffusion.cpp
that referenced
this pull request
Apr 5, 2026
(cherry picked from commit f48d7fc)
|
This PR has been inactive for 365 days. If there is no new activity within 7 days, it will be closed automatically. Comment, push new commits, or remove the pr:inactive label to keep it open. Add pr:keep-open to exempt it from future inactive PR cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not setting up the compute graph twice might result in a minor (/negligible?) performance improvement.
Previously it worked like the following in GGMLRunner#compute:
1.1 calls reset_compute_ctx
1.2 calls get_graph
Tested on cpu and vulkan locally.