Task list improvements (#195)

* chore: bump cn to 0.2.6 and remove duplicate @fontsource-variable/inter entry

* feat: add Accordion component with trigger and content functionality

* feat: integrate TooltipProvider into App and test wrappers

* feat: TaskList improvements

* test: improve error handling in TaskDeleteDialog tests and update mock response status

* fix: add aria-label to DropdownMenuTrigger for accessibility

* feat: add Tooltip to LanguageToggle

* feat: add Tooltip to LanguageToggle and ThemeToggle

* feat: implement i18n support for AppSidebar and AppSidebarTrigger components

* feat: add sign-in button to Header component with translation support

* feat: add cursor pointer style to interactive components for better UX

* feat: refactor TaskDeleteDialog to use trigger prop and navigate on success

* refactor: move mock setup for react-router-dom outside of describe block in TaskEdit tests

* chore: shadcn migrate cn

* test: AddTaskButton unit tests

* feat: enhance task update feedback with localized messages

Author: mwarman

package-lock.json

@@ -16,13 +16,14 @@
     "test:coverage": "vitest run --coverage --silent passed-only"
   },
   "dependencies": {
+    "@fontsource-variable/inter": "5.3.0",
     "@fortawesome/fontawesome-svg-core": "7.3.1",
     "@fortawesome/free-regular-svg-icons": "7.3.1",
     "@fortawesome/free-solid-svg-icons": "7.3.1",
     "@fortawesome/react-fontawesome": "3.5.0",
-    "@fontsource-variable/inter": "5.3.0",
     "class-variance-authority": "0.7.1",
     "clsx": "2.1.1",
+    "cn": "0.2.6",
     "next-themes": "0.4.6",
     "radix-ui": "1.6.7",
     "react-syntax-highlighter": "16.1.1",

packages/shared/package.json

@@ -0,0 +1,60 @@
+import * as React from 'react';
+import { cn } from 'cn';
+import { Accordion as AccordionPrimitive } from 'radix-ui';
+import { ChevronDownIcon, ChevronUpIcon } from 'lucide-react';
+
+function Accordion({ className, ...props }: React.ComponentProps<typeof AccordionPrimitive.Root>) {
+  return <AccordionPrimitive.Root data-slot="accordion" className={cn('flex w-full flex-col', className)} {...props} />;
+}
+
+function AccordionItem({ className, ...props }: React.ComponentProps<typeof AccordionPrimitive.Item>) {
+  return (
+    <AccordionPrimitive.Item data-slot="accordion-item" className={cn('not-last:border-b', className)} {...props} />
+  );
+}
+
+function AccordionTrigger({ className, children, ...props }: React.ComponentProps<typeof AccordionPrimitive.Trigger>) {
+  return (
+    <AccordionPrimitive.Header className="flex">
+      <AccordionPrimitive.Trigger
+        data-slot="accordion-trigger"
+        className={cn(
+          'group/accordion-trigger focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:after:border-ring **:data-[slot=accordion-trigger-icon]:text-muted-foreground relative flex flex-1 items-start justify-between rounded-lg border border-transparent py-2.5 text-left text-sm font-medium transition-all outline-none hover:underline focus-visible:ring-3 disabled:pointer-events-none disabled:opacity-50 **:data-[slot=accordion-trigger-icon]:ml-auto **:data-[slot=accordion-trigger-icon]:size-4',
+          className,
+        )}
+        {...props}
+      >
+        {children}
+        <ChevronDownIcon
+          data-slot="accordion-trigger-icon"
+          className="pointer-events-none shrink-0 group-aria-expanded/accordion-trigger:hidden"
+        />
+        <ChevronUpIcon
+          data-slot="accordion-trigger-icon"
+          className="pointer-events-none hidden shrink-0 group-aria-expanded/accordion-trigger:inline"
+        />
+      </AccordionPrimitive.Trigger>
+    </AccordionPrimitive.Header>
+  );
+}
+
+function AccordionContent({ className, children, ...props }: React.ComponentProps<typeof AccordionPrimitive.Content>) {
+  return (
+    <AccordionPrimitive.Content
+      data-slot="accordion-content"
+      className="data-open:animate-accordion-down data-closed:animate-accordion-up overflow-hidden text-sm"
+      {...props}
+    >
+      <div
+        className={cn(
+          '[&_a]:hover:text-foreground h-(--radix-accordion-content-height) pt-0 pb-2.5 [&_a]:underline [&_a]:underline-offset-3 [&_p:not(:last-child)]:mb-4',
+          className,
+        )}
+      >
+        {children}
+      </div>
+    </AccordionPrimitive.Content>
+  );
+}
+
+export { Accordion, AccordionItem, AccordionTrigger, AccordionContent };

packages/shared/src/components/shadcn/accordion.tsx

@@ -1,21 +1,2 @@
-/**
- * @module css
- * @description Utility functions for handling CSS class names, particularly in the context of Tailwind CSS.
- * This module provides a function to conditionally construct `className` strings and merge Tailwind CSS classes without conflicts.
- * It leverages the `clsx` library for conditional class name construction and the `tailwind-merge` library for merging Tailwind CSS classes.
- * @see {@link https://github.com/lukeed/clsx} for `clsx` documentation.
- * @see {@link https://github.com/dcastil/tailwind-merge} for `tailwind-merge` documentation.
- */
-
-import { clsx, type ClassValue } from 'clsx';
-import { twMerge } from 'tailwind-merge';
-
-/**
- * Conditionally construct `className` strings. Merge Tailwind CSS classes
- * without conflicts.
- * @param inputs - Class values used to calculate the `className` value.
- * @returns {string} - A consolidated string containing CSS class names.
- */
-export const cn = (...inputs: ClassValue[]): string => {
-  return twMerge(clsx(inputs));
-};
+// Backwards compatibility for the `cn` utility function for shadcn.
+export { cn } from 'cn';

packages/shared/src/utils/css.test.ts

@@ -25,7 +25,12 @@ export default mergeConfig(
       include: ['src/**/*.test.ts', 'src/**/*.test.tsx'],
       coverage: {
         include: ['src/**/*.ts', 'src/**/*.tsx'],
-        exclude: ['src/components/shadcn/**', ...coverageConfigDefaults.exclude],
+        exclude: [
+          'src/components/shadcn/**',
+          'src/utils/css.ts',
+          'src/hooks/use-mobile.ts',
+          ...coverageConfigDefaults.exclude,
+        ],
       },
     },
   }),

packages/shared/src/utils/css.ts

@@ -3,6 +3,7 @@ import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 import { ReactQueryDevtools } from '@tanstack/react-query-devtools';
 
 import { Toaster } from '@react-starter/shared/components/shadcn/sonner';
+import { TooltipProvider } from '@react-starter/shared/components/shadcn/tooltip';
 
 import ErrorBoundary from '@/common/components/Errors/ErrorBoundary';
 import ErrorFallback from '@/common/components/Errors/ErrorFallback';
@@ -29,7 +30,7 @@ const queryClient = new QueryClient({
  * The application. The outermost component of the React application
  * hierarchy. Declares application-wide providers.
  */
-export const App = () => {
+const App = () => {
   return (
     <div id="app" className="bg-background text-foreground min-h-screen" data-testid="app">
       <ErrorBoundary fallback={<ErrorFallback />}>
@@ -38,8 +39,10 @@ export const App = () => {
             <Theme />
             <AuthContextProvider>
               <AxiosContextProvider>
-                <RouterProvider router={router} />
-                <Toaster />
+                <TooltipProvider>
+                  <RouterProvider router={router} />
+                  <Toaster />
+                </TooltipProvider>
               </AxiosContextProvider>
             </AuthContextProvider>
             <ReactQueryDevtools initialIsOpen={false} />
@@ -49,3 +52,5 @@ export const App = () => {
     </div>
   );
 };
+
+export { App };

packages/shared/vitest.config.ts

@@ -1,4 +1,4 @@
-import { Task } from '@/pages/Tasks/api/useGetUserTasks';
+import type { Task } from '@/common/types/task';
 
 export const todosFixture: Task[] = [
   {

packages/web/src/App.tsx

@@ -13,7 +13,7 @@ vi.mock('react-i18next', async () => {
   const original = await vi.importActual('react-i18next');
   return {
     ...original,
-    useTranslation: () => ({ i18n: { changeLanguage: mockChangeLanguage } }),
+    useTranslation: () => ({ i18n: { changeLanguage: mockChangeLanguage }, t: vi.fn() }),
   };
 });
 

packages/web/src/__fixtures__/todos.ts

@@ -12,13 +12,14 @@ import {
   DropdownMenuItem,
 } from '@react-starter/shared/components/shadcn/dropdown-menu';
 import { Button } from '@react-starter/shared/components/shadcn/button';
+import { Tooltip, TooltipContent, TooltipTrigger } from '@react-starter/shared/components/shadcn/tooltip';
 
 /**
  * The `LanguageToggle` component renders a `Dropdown` which allows users
  * to select the language in which they wish to view the application.
  */
 export const LanguageToggle = () => {
-  const { i18n } = useTranslation();
+  const { i18n, t } = useTranslation();
 
   /**
    * Set the application-wide langague code used for i18n.
@@ -31,21 +32,32 @@ export const LanguageToggle = () => {
 
   return (
     <DropdownMenu data-testid="dropdown-language">
-      <DropdownMenuTrigger asChild>
-        <Button variant="outline" size="icon" title="Select Language" data-testid="button-language-menu-trigger">
-          <Languages aria-label="Select Language" data-testid="icon-language" />
-        </Button>
-      </DropdownMenuTrigger>
-      <DropdownMenuContent align="end" className="w-32">
+      <Tooltip>
+        <TooltipTrigger asChild>
+          <DropdownMenuTrigger asChild>
+            <Button
+              variant="outline"
+              size="icon"
+              className="cursor-pointer"
+              aria-label={t('select-language')}
+              data-testid="button-language-menu-trigger"
+            >
+              <Languages data-testid="icon-language" />
+            </Button>
+          </DropdownMenuTrigger>
+        </TooltipTrigger>
+        <TooltipContent>{t('select-language')}</TooltipContent>
+      </Tooltip>
+      <DropdownMenuContent align="end" className="w-32" onCloseAutoFocus={(e) => e.preventDefault()}>
         <DropdownMenuGroup>
           <DropdownMenuLabel>Languages</DropdownMenuLabel>
-          <DropdownMenuItem onClick={() => setLanguage('en')} data-testid="dropdown-item-en">
+          <DropdownMenuItem className="cursor-pointer" onClick={() => setLanguage('en')} data-testid="dropdown-item-en">
             English
           </DropdownMenuItem>
-          <DropdownMenuItem onClick={() => setLanguage('fr')} data-testid="dropdown-item-fr">
+          <DropdownMenuItem className="cursor-pointer" onClick={() => setLanguage('fr')} data-testid="dropdown-item-fr">
             French
           </DropdownMenuItem>
-          <DropdownMenuItem onClick={() => setLanguage('es')} data-testid="dropdown-item-es">
+          <DropdownMenuItem className="cursor-pointer" onClick={() => setLanguage('es')} data-testid="dropdown-item-es">
             Spanish
           </DropdownMenuItem>
         </DropdownMenuGroup>