From 1f3aecd8746b3f6935c84cf68081d5d9b5b112b4 Mon Sep 17 00:00:00 2001 From: mcfnord Date: Tue, 8 Sep 2026 00:45:06 +0000 Subject: [PATCH] Return "ok" from setSkillLevel when skillLevel is null The null branch of jamulusclient/setSkillLevel cleared the skill level and returned without assigning response["result"], so the reply carried neither "result" nor "error", which JSON-RPC 2.0 forbids. The method documents its result as always "ok"; now it is. Fixes #3919 --- src/clientrpc.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/clientrpc.cpp b/src/clientrpc.cpp index 0f376d10b4..67f46a9843 100644 --- a/src/clientrpc.cpp +++ b/src/clientrpc.cpp @@ -305,6 +305,7 @@ CClientRpc::CClientRpc ( CClient* pClient, CClientSettings* pSettings, CRpcServe { pClient->ChannelInfo.eSkillLevel = SL_NOT_SET; pClient->SetRemoteInfo(); + response["result"] = "ok"; return; }