Skip to content

Allow Brave to update the adblock components #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimterry merged 1 commit into from
May 21, 2026
Merged

Allow Brave to update the adblock components #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/interceptors/chromium-based-interceptors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const getChromiumLaunchOptions = async (
): Promise<LaunchOptions & { options: Required<LaunchOptions>['options'] }> => {
const certificatePem = await readFile(config.https.certPath, 'utf8');
const spkiFingerprint = await generateSPKIFingerprint(certificatePem);
const isBrave = browser.toLowerCase() === 'brave';

return {
profile: profilePath,
Expand Down Expand Up @@ -61,10 +62,15 @@ const getChromiumLaunchOptions = async (
].join(','),
// Avoid annoying extra network noise:
'--disable-background-networking',
// Disable component update (without disabling components themselves, e.g. widevine)
// See https://bugs.chromium.org/p/chromium/issues/detail?id=331932
'--component-updater=url-source=http://disabled-chromium-update.localhost:0',
'--check-for-update-interval=31536000', // Don't update for a year
// Allow Brave to update the adblock components
...(!isBrave
? [
// Disable component update (without disabling components themselves, e.g. widevine)
// See https://bugs.chromium.org/p/chromium/issues/detail?id=331932
'--component-updater=url-source=http://disabled-chromium-update.localhost:0',
'--check-for-update-interval=31536000', // Don't update for a year
]
: []),
...(webExtensionEnabled && WEBEXTENSION_INSTALL
? [
`--load-extension=${WEBEXTENSION_INSTALL.path}`
Expand Down
Loading