Allow Brave to update the adblock components#219
Merged
Conversation
|
|
Member
|
Great stuff, thanks @H1steria! Glad we could find a fix for this. I'll need a little time to wrap up some things and release this officially, but of course you can use it in your server dev setup locally anyway in the meantime. I'll close #896 now. By the way, in case you're not aware, HTTP Toolkit Pro is free for all contributors to all https://github.com/httptoolkit repos. I've just enabled that for your git commit email address (s***@gmail.com), just click 'Get Pro' then 'Log into existing account' and enter your email to get started. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brave's integrated adblock don't works because can't update components.
httptoolkit/httptoolkit#896