more logging issues

Author: rweigel

hapiclient/log.py

@@ -26,7 +26,7 @@ def configure_logging(logging):
     has_user_handlers = any(
         not getattr(handler, _INTERNAL_HANDLER_ATTR, False)
         for handler in _logger.handlers
-    )
+    ) or bool(_logging.root.handlers)
 
     if logging is True:
         _logger.setLevel(_logging.INFO)
@@ -39,8 +39,10 @@ def configure_logging(logging):
             _handler.setFormatter(_logging.Formatter("%(message)s"))
             setattr(_handler, _INTERNAL_HANDLER_ATTR, True)
             _logger.addHandler(_handler)
+
     if logging is False:
         if has_user_level or has_user_handlers:
+            _logger.propagate = True  # ensure messages reach the user-configured handler
             #from .util import warning
             if has_user_handlers:
                 pass

misc/hapi_logging_demo.py

@@ -43,13 +43,8 @@ def reset_hapiclient_logging():
   # 2. Log to console using Python's standard logging module
   if 4 <= method <= 6:
     import logging
-    logger = logging.getLogger("hapiclient")
-    logger.setLevel(logging.INFO)
-    handler = logging.StreamHandler()
-    formatter = logging.Formatter("%(asctime)s [%(name)s] %(message)s", datefmt="%Y-%m-%dT%H:%M:%S")
-    formatter.default_msec_format = '%s.%03d'
-    handler.setFormatter(formatter)
-    logger.addHandler(handler)
+
+    logging.basicConfig(level=logging.INFO, format="%(asctime)s [%(name)s] %(message)s", datefmt="%Y-%m-%dT%H:%M:%S")
 
     if method == 4:
       # Use standard logging because defined

test/test_cache.py

@@ -20,6 +20,8 @@
 start = '1970-01-01'
 stop  = '1970-01-01T00:00:03'
 
+import pytest
+
 def test_cache_short():
 
     # Compare read with empty cache with read with hot cache and usecache=True
@@ -36,23 +38,21 @@ def test_cache_short():
     assert compare.equal(data, data2)
 
 
+@pytest.mark.filterwarnings("ignore::hapiclient.util.HAPIWarning")
 def test_cache_error():
 
     from unittest.mock import patch
 
-    import io
-    import contextlib
     import pathlib
     import tempfile
     from hapiclient.util import write_atomic
 
+    from hapiclient.util import HAPIWarning
+
     def assert_warns(fn, expected):
-        buf = io.StringIO()
-        with contextlib.redirect_stderr(buf):
+        import pytest
+        with pytest.warns(HAPIWarning, match=expected):
             result = fn()
-            print(buf.getvalue())
-        msg = f"Expected '{expected}' in stderr: {buf.getvalue()!r}"
-        assert expected in buf.getvalue(), msg
         return result
 
     # Direct calls to write_atomic()