Repository navigation
Commit 6e1357f
committed
Security report: one row for repeated false alarms, and fewer of them
A report on this repository listed one Django CSRF rule nineteen times,
once per template, and still carried false positives the code disproved.
Closed issues with the same rule and the same verdict are now one row that
names every file and covers every finding. A real issue is never folded in.
A rule named for a framework, such as django-no-csrf-token, is now set aside
in code when the repository does not use that framework, instead of being
asked about once per file. A framework counts as used when a build file
names it or the code imports it, so a missing requirements file never hides
a real finding. Test fixtures and tool folders are not read for this.
The policy reader no longer takes a sentence about a Content-Security-Policy
for a policy: every source in a directive has to look like one.
The review is told a protection can sit in the code that calls the flagged
code, and to ask for it. A search that lands on a definition now brings the
whole definition, so the check its body makes is in view.
The first admin docstring said the password goes to the log. It goes only
to a file at mode 600, which the log names, and the docstring now says so.
The credential import warning logs the error type, not its text, since a
database error can echo the values it was handed.1 parent 4a758df commit 6e1357f
4 files changed
Lines changed: 176 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
407 | | - | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
408 | 410 | | |
409 | 411 | | |
410 | 412 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
957 | 957 | | |
958 | 958 | | |
959 | 959 | | |
960 | | - | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
961 | 966 | | |
962 | 967 | | |
963 | 968 | | |
| |||
1547 | 1552 | | |
1548 | 1553 | | |
1549 | 1554 | | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
1550 | 1602 | | |
1551 | 1603 | | |
1552 | 1604 | | |
| |||
1588 | 1640 | | |
1589 | 1641 | | |
1590 | 1642 | | |
| 1643 | + | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
| 1660 | + | |
| 1661 | + | |
| 1662 | + | |
| 1663 | + | |
| 1664 | + | |
| 1665 | + | |
| 1666 | + | |
| 1667 | + | |
| 1668 | + | |
| 1669 | + | |
1591 | 1670 | | |
1592 | 1671 | | |
1593 | 1672 | | |
| |||
1624 | 1703 | | |
1625 | 1704 | | |
1626 | 1705 | | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
1627 | 1711 | | |
1628 | 1712 | | |
1629 | 1713 | | |
| |||
2156 | 2240 | | |
2157 | 2241 | | |
2158 | 2242 | | |
| 2243 | + | |
| 2244 | + | |
| 2245 | + | |
| 2246 | + | |
2159 | 2247 | | |
2160 | 2248 | | |
2161 | 2249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
151 | 155 | | |
152 | 156 | | |
153 | 157 | | |
| |||
232 | 236 | | |
233 | 237 | | |
234 | 238 | | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
235 | 260 | | |
236 | 261 | | |
237 | 262 | | |
| |||
250 | 275 | | |
251 | 276 | | |
252 | 277 | | |
| 278 | + | |
| 279 | + | |
253 | 280 | | |
254 | 281 | | |
255 | 282 | | |
| |||
304 | 331 | | |
305 | 332 | | |
306 | 333 | | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
307 | 382 | | |
308 | 383 | | |
309 | 384 | | |
| |||
316 | 391 | | |
317 | 392 | | |
318 | 393 | | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
319 | 399 | | |
320 | 400 | | |
321 | 401 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
151 | 153 | | |
152 | 154 | | |
153 | 155 | | |
| |||
0 commit comments